Optimize the pre-paint tree walk and ClipRects

Optimize the pre-paint tree walk and ClipRects.

1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html of up to 5%.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2784963002
Cr-Commit-Position: refs/heads/master@{#460808}
Committed: https://chromium.googlesource.com/chromium/src/+/65b5d60ab86950a42ade9f0aee9e5e67d8c3ff20

[chrishtr, 2017-03-29 20:50:40]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-29 21:02:09]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-03-29 21:03:19]

Description was changed from

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
1. Avoid malloc for ClipRects objects.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomtryMapper
now checks for transforms on infininte rects instead).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-03-29 21:03:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:13:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-03-30 00:41:15]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 00:41:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 02:48:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 02:48:42]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-03-30 16:47:30]

Description was changed from

==========
1. Avoid malloc for ClipRects objects.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomtryMapper
now checks for transforms on infininte rects instead).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html. I am also running a CT analysis with and without
SPInvalidation on to see effect on paint times. Early data suggests no
strong change either way. (though note that this CL is mainly aimed at reducing
time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-30 16:48:26]

Description was changed from

==========
1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html. I am also running a CT analysis with and without
SPInvalidation on to see effect on paint times. Early data suggests no
strong change either way. (though note that this CL is mainly aimed at reducing
time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html, though the data was not strongly
conclusive.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-30 16:50:08]

Description was changed from

==========
1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html, though the data was not strongly
conclusive.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html of up to 5%.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-30 16:50:59]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org, wangxianzhu@chromium.org

[chrishtr, 2017-03-30 16:50:59]

I suggest committing this and then observing the bots. WDYT?

[chrishtr, 2017-03-30 16:51:18]

https://codereview.chromium.org/2784963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ClipRects.h (left):

https://codereview.chromium.org/2784963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ClipRects.h:2: * Copyright (C) 2003, 2009,
2012 Apple Inc. All rights reserved.
I forgot to delete this in an earlier refactoring patch.

[Xianzhu, 2017-03-30 16:54:53]

lgtm.

Please put the one-line summary in the description.

[chrishtr, 2017-03-30 17:12:24]

Description was changed from

==========
1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html of up to 5%.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Optimize the pre-paint tree walk and ClipRects.

1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html of up to 5%.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-30 17:12:31]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-30 17:12:48]

Ok committing now. Happy to revert if there is a negative impact found.

[commit-bot: I haz the power, 2017-03-30 17:12:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 17:18:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490893951255850,
"parent_rev": "b5acc4c7976d45ace977c14019593c9413d0841d", "commit_rev":
"65b5d60ab86950a42ade9f0aee9e5e67d8c3ff20"}

[commit-bot: I haz the power, 2017-03-30 17:19:32]

Description was changed from

==========
Optimize the pre-paint tree walk and ClipRects.

1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html of up to 5%.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Optimize the pre-paint tree walk and ClipRects.

1. Avoid malloc for ClipRects objects. This trades reduced malloc for
a somewhat larger PaintLayer.
2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.

Local runs showed pre-paint time improvements in about:tracing for
Paint/containment-resize.html of up to 5%.

I am also running a CT analysis with and without SPInvalidation on to see effect
on paint times. Early data suggests no strong change either way. (though note
that
this CL is mainly aimed at reducing time in pre-paint).

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2784963002
Cr-Commit-Position: refs/heads/master@{#460808}
Committed:
https://chromium.googlesource.com/chromium/src/+/65b5d60ab86950a42ade9f0aee9e...
==========

[commit-bot: I haz the power, 2017-03-30 17:19:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/65b5d60ab86950a42ade9f0aee9e...

[chrishtr, 2017-04-02 17:02:42]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2792833002/ by chrishtr@chromium.org.

The reason for reverting is: On further investigation, found that this patch
introduces too much inefficiency by
making all PaintLayers pay the cost of a ClipRects object, rather than just ones
that
induce subsequences..