Rewrite base::Bind into base::BindOnce on trivial cases in base

Rewrite base::Bind into base::BindOnce on trivial cases in base

This CL is generated by a clang refactoring tool updated in
http://crrev.com/2789153002/, that rewrites base::Bind into base::BindOnce
where the resulting base::Callback is converted into base::OnceCallback
immediately after base::Bind call.

Review-Url: https://codereview.chromium.org/2791243002
Cr-Commit-Position: refs/heads/master@{#463631}
Committed: https://chromium.googlesource.com/chromium/src/+/92b7a42d1fa69917d19ec389a0cd254328920c7a

[tzik, 2017-04-03 13:22:36]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 13:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:56:52]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-05 10:22:46]

Description was changed from

==========
Apply base_bind_rewriters for BindOnce to //base
==========

to

==========
Rewrite base::Bind into base::BindOnce on trivial cases in base

This CL is generated by a clang refactoring tool updated in
http://crrev.com/2789153002/, that rewrites base::Bind into base::BindOnce
where the resulting base::Callback is converted into base::OnceCallback
immediately after base::Bind call.
==========

[tzik, 2017-04-05 10:46:33]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org, gab@chromium.org

[tzik, 2017-04-05 10:46:33]

PTAL

[chromium-reviews, 2017-04-05 14:28:54]

drive-by nit: add BUG= to the CL description with a bug id that tracks this
work

On Wed, Apr 5, 2017 at 6:46 AM, <tzik@chromium.org> wrote:

> Reviewers: gab, dcheng
> CL: https://codereview.chromium.org/2791243002/
>
> Message:
> PTAL
>
> Description:
> Rewrite base::Bind into base::BindOnce on trivial cases in base
>
> This CL is generated by a clang refactoring tool updated in
> http://crrev.com/2789153002/, that rewrites base::Bind into base::BindOnce
> where the resulting base::Callback is converted into base::OnceCallback
> immediately after base::Bind call.
>
>
> Affected files (+638, -604 lines):
> M base/debug/activity_tracker.cc
> M base/debug/activity_tracker_unittest.cc
> M base/debug/task_annotator_unittest.cc
> M base/deferred_sequenced_task_runner_unittest.cc
> M base/files/file_descriptor_watcher_posix.cc
> M base/files/file_path_watcher_linux.cc
> M base/files/file_path_watcher_unittest.cc
> M base/files/file_proxy.cc
> M base/files/file_util_proxy.cc
> M base/files/important_file_writer_unittest.cc
> M base/memory/weak_ptr_unittest.cc
> M base/message_loop/message_loop_task_runner_unittest.cc
> M base/message_loop/message_loop_test.cc
> M base/message_loop/message_loop_unittest.cc
> M base/message_loop/message_pump_glib_unittest.cc
> M base/message_loop/message_pump_libevent_unittest.cc
> M base/message_loop/message_pump_perftest.cc
> M base/metrics/user_metrics.cc
> M base/observer_list_threadsafe.h
> M base/observer_list_unittest.cc
> M base/posix/unix_domain_socket_linux_unittest.cc
> M base/process/process_metrics_unittest.cc
> M base/run_loop_unittest.cc
> M base/sequence_checker_unittest.cc
> M base/sequenced_task_runner.cc
> M base/sequenced_task_runner_unittest.cc
> M base/synchronization/atomic_flag_unittest.cc
> M base/synchronization/condition_variable_unittest.cc
> M base/task/cancelable_task_tracker.cc
> M base/task/cancelable_task_tracker_unittest.cc
> M base/task_runner_util.h
> M base/task_scheduler/delayed_task_manager.cc
> M base/task_scheduler/scheduler_single_thread_task_runner_
> manager_unittest.cc
> M base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
> M base/task_scheduler/scheduler_worker_unittest.cc
> M base/task_scheduler/task_scheduler_impl_unittest.cc
> M base/task_scheduler/task_tracker_unittest.cc
> M base/task_scheduler/task_unittest.cc
> M base/task_scheduler/test_task_factory.cc
> M base/test/launcher/test_launcher.cc
> M base/test/launcher/unit_test_launcher.cc
> M base/test/scoped_mock_time_message_loop_task_runner.cc
> M base/test/scoped_task_scheduler.cc
> M base/test/scoped_task_scheduler_unittest.cc
> M base/test/thread_test_helper.cc
> M base/threading/post_task_and_reply_impl.cc
> M base/threading/post_task_and_reply_impl_unittest.cc
> M base/threading/sequenced_task_runner_handle_unittest.cc
> M base/threading/sequenced_worker_pool_unittest.cc
> M base/threading/thread.cc
> M base/threading/thread_perftest.cc
> M base/threading/thread_unittest.cc
> M base/threading/worker_pool_unittest.cc
> M base/timer/timer.cc
> M base/trace_event/memory_dump_manager.cc
> M base/trace_event/memory_dump_manager_unittest.cc
> M base/trace_event/memory_dump_scheduler.cc
> M base/trace_event/trace_category_unittest.cc
> M base/trace_event/trace_event_system_stats_monitor.cc
> M base/trace_event/trace_event_unittest.cc
> M base/trace_event/trace_log.cc
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dcheng, 2017-04-05 16:49:50]

LGTM

(But please add a BUG= line for tracking purposes, as mentioned by alexclarke@)

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
base/sequence_checker_unittest.cc:254:
base::BindOnce(&ExpectNotCalledOnValidSequence,
Nit: I noticed a few unnecessary base:: qualifications, but since this CL is
automated (and the conditions are pre-existing), let's not worry about it.

[gab, 2017-04-06 15:08:46]

gab@chromium.org changed reviewers:
+ fdoray@chromium.org

[gab, 2017-04-06 15:08:47]

+fdoray for question below

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
base/sequence_checker_unittest.cc:254:
base::BindOnce(&ExpectNotCalledOnValidSequence,
On 2017/04/05 16:49:50, dcheng wrote:
> Nit: I noticed a few unnecessary base:: qualifications, but since this CL is
> automated (and the conditions are pre-existing), let's not worry about it.

fdoray actually had a way to only add base:: where necessary in a clang-tidy
script of his

[fdoray, 2017-04-06 15:42:37]

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
base/sequence_checker_unittest.cc:254:
base::BindOnce(&ExpectNotCalledOnValidSequence,
On 2017/04/06 15:08:47, gab wrote:
> On 2017/04/05 16:49:50, dcheng wrote:
> > Nit: I noticed a few unnecessary base:: qualifications, but since this CL is
> > automated (and the conditions are pre-existing), let's not worry about it.
> 
> fdoray actually had a way to only add base:: where necessary in a clang-tidy
> script of his

The magic is here:
https://bugs.chromium.org/p/chromium/issues/detail?id=612843#c13. I can provide
help if needed, but since this CL only affects base/, I think it would be faster
to s/base::BindOnce/BindOnce/ + manually fix files that don't compile.

[tzik, 2017-04-11 12:11:21]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 12:11:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-11 12:15:02]

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
File base/sequence_checker_unittest.cc (right):

https://codereview.chromium.org/2791243002/diff/1/base/sequence_checker_unitt...
base/sequence_checker_unittest.cc:254:
base::BindOnce(&ExpectNotCalledOnValidSequence,
On 2017/04/06 15:42:37, fdoray wrote:
> On 2017/04/06 15:08:47, gab wrote:
> > On 2017/04/05 16:49:50, dcheng wrote:
> > > Nit: I noticed a few unnecessary base:: qualifications, but since this CL
is
> > > automated (and the conditions are pre-existing), let's not worry about it.
> > 
> > fdoray actually had a way to only add base:: where necessary in a clang-tidy
> > script of his
> 
> The magic is here:
> https://bugs.chromium.org/p/chromium/issues/detail?id=612843#c13. I can
provide
> help if needed, but since this CL only affects base/, I think it would be
faster
> to s/base::BindOnce/BindOnce/ + manually fix files that don't compile.

The number of base::Bind{,Once} seems large to do in this CL. Let me do it
separately.

[commit-bot: I haz the power, 2017-04-11 13:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 13:18:23]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-11 14:51:26]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-04-11 14:51:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2791243002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-11 14:51:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 15:00:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491922286541420,
"parent_rev": "df600cdcab705df0e7a43823c1bca99924542cb4", "commit_rev":
"92b7a42d1fa69917d19ec389a0cd254328920c7a"}

[commit-bot: I haz the power, 2017-04-11 15:01:58]

Description was changed from

==========
Rewrite base::Bind into base::BindOnce on trivial cases in base

This CL is generated by a clang refactoring tool updated in
http://crrev.com/2789153002/, that rewrites base::Bind into base::BindOnce
where the resulting base::Callback is converted into base::OnceCallback
immediately after base::Bind call.
==========

to

==========
Rewrite base::Bind into base::BindOnce on trivial cases in base

This CL is generated by a clang refactoring tool updated in
http://crrev.com/2789153002/, that rewrites base::Bind into base::BindOnce
where the resulting base::Callback is converted into base::OnceCallback
immediately after base::Bind call.

Review-Url: https://codereview.chromium.org/2791243002
Cr-Commit-Position: refs/heads/master@{#463631}
Committed:
https://chromium.googlesource.com/chromium/src/+/92b7a42d1fa69917d19ec389a0cd...
==========

[commit-bot: I haz the power, 2017-04-11 15:01:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92b7a42d1fa69917d19ec389a0cd...