Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: base/memory/weak_ptr_unittest.cc

Issue 2791243002: Rewrite base::Bind into base::BindOnce on trivial cases in base (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/weak_ptr_unittest.cc
diff --git a/base/memory/weak_ptr_unittest.cc b/base/memory/weak_ptr_unittest.cc
index 1a4870eab184e39f80fa2dd3d2b7abb797d61ab3..d223bd2bf6d801379f5aa85372cf7be7d3ae50bc 100644
--- a/base/memory/weak_ptr_unittest.cc
+++ b/base/memory/weak_ptr_unittest.cc
@@ -32,7 +32,8 @@ class OffThreadObjectCreator {
Thread creator_thread("creator_thread");
creator_thread.Start();
creator_thread.task_runner()->PostTask(
- FROM_HERE, base::Bind(OffThreadObjectCreator::CreateObject, &result));
+ FROM_HERE,
+ base::BindOnce(OffThreadObjectCreator::CreateObject, &result));
}
DCHECK(result); // We synchronized on thread destruction above.
return result;
@@ -73,8 +74,8 @@ class BackgroundThread : public Thread {
WaitableEvent completion(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
task_runner()->PostTask(
- FROM_HERE, base::Bind(&BackgroundThread::DoCreateArrowFromTarget, arrow,
- target, &completion));
+ FROM_HERE, base::BindOnce(&BackgroundThread::DoCreateArrowFromTarget,
+ arrow, target, &completion));
completion.Wait();
}
@@ -82,8 +83,8 @@ class BackgroundThread : public Thread {
WaitableEvent completion(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
task_runner()->PostTask(
- FROM_HERE, base::Bind(&BackgroundThread::DoCreateArrowFromArrow, arrow,
- other, &completion));
+ FROM_HERE, base::BindOnce(&BackgroundThread::DoCreateArrowFromArrow,
+ arrow, other, &completion));
completion.Wait();
}
@@ -92,7 +93,7 @@ class BackgroundThread : public Thread {
WaitableEvent::InitialState::NOT_SIGNALED);
task_runner()->PostTask(
FROM_HERE,
- base::Bind(&BackgroundThread::DoDeleteTarget, object, &completion));
+ base::BindOnce(&BackgroundThread::DoDeleteTarget, object, &completion));
completion.Wait();
}
@@ -100,8 +101,8 @@ class BackgroundThread : public Thread {
WaitableEvent completion(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
task_runner()->PostTask(
- FROM_HERE, base::Bind(&BackgroundThread::DoCopyAndAssignArrow, object,
- &completion));
+ FROM_HERE, base::BindOnce(&BackgroundThread::DoCopyAndAssignArrow,
+ object, &completion));
completion.Wait();
}
@@ -109,8 +110,8 @@ class BackgroundThread : public Thread {
WaitableEvent completion(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
task_runner()->PostTask(
- FROM_HERE, base::Bind(&BackgroundThread::DoCopyAndAssignArrowBase,
- object, &completion));
+ FROM_HERE, base::BindOnce(&BackgroundThread::DoCopyAndAssignArrowBase,
+ object, &completion));
completion.Wait();
}
@@ -119,7 +120,7 @@ class BackgroundThread : public Thread {
WaitableEvent::InitialState::NOT_SIGNALED);
task_runner()->PostTask(
FROM_HERE,
- base::Bind(&BackgroundThread::DoDeleteArrow, object, &completion));
+ base::BindOnce(&BackgroundThread::DoDeleteArrow, object, &completion));
completion.Wait();
}
@@ -127,8 +128,9 @@ class BackgroundThread : public Thread {
WaitableEvent completion(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
Target* result = nullptr;
- task_runner()->PostTask(FROM_HERE, base::Bind(&BackgroundThread::DoDeRef,
- arrow, &result, &completion));
+ task_runner()->PostTask(
+ FROM_HERE, base::BindOnce(&BackgroundThread::DoDeRef, arrow, &result,
+ &completion));
completion.Wait();
return result;
}
« no previous file with comments | « base/files/important_file_writer_unittest.cc ('k') | base/message_loop/message_loop_task_runner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698