Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: base/task_scheduler/task_tracker_unittest.cc

Issue 2791243002: Rewrite base::Bind into base::BindOnce on trivial cases in base (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl_unittest.cc ('k') | base/task_scheduler/task_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_tracker_unittest.cc
diff --git a/base/task_scheduler/task_tracker_unittest.cc b/base/task_scheduler/task_tracker_unittest.cc
index 0005e6ce15dab9db56b193529cf7c175e5182076..1c9b0a8d01963b9c7c50ec57994a2dbe15c3d25f 100644
--- a/base/task_scheduler/task_tracker_unittest.cc
+++ b/base/task_scheduler/task_tracker_unittest.cc
@@ -428,7 +428,7 @@ TEST_P(TaskSchedulerTaskTrackerTest, SingletonAllowed) {
TaskTracker tracker;
std::unique_ptr<Task> task(
- new Task(FROM_HERE, Bind(&ThreadRestrictions::AssertSingletonAllowed),
+ new Task(FROM_HERE, BindOnce(&ThreadRestrictions::AssertSingletonAllowed),
TaskTraits().WithShutdownBehavior(GetParam()), TimeDelta()));
EXPECT_TRUE(tracker.WillPostTask(task.get()));
@@ -502,7 +502,7 @@ TEST_P(TaskSchedulerTaskTrackerTest, TaskRunnerHandleIsNotSetOnParallel) {
// Create a task that will verify that TaskRunnerHandles are not set in its
// scope per no TaskRunner ref being set to it.
std::unique_ptr<Task> verify_task(
- new Task(FROM_HERE, Bind(&VerifyNoTaskRunnerHandle),
+ new Task(FROM_HERE, BindOnce(&VerifyNoTaskRunnerHandle),
TaskTraits().WithShutdownBehavior(GetParam()), TimeDelta()));
RunTaskRunnerHandleVerificationTask(&tracker_, std::move(verify_task));
@@ -523,8 +523,9 @@ TEST_P(TaskSchedulerTaskTrackerTest,
// set to |test_task_runner| in its scope per |sequenced_task_runner_ref|
// being set to it.
std::unique_ptr<Task> verify_task(
- new Task(FROM_HERE, Bind(&VerifySequencedTaskRunnerHandle,
- base::Unretained(test_task_runner.get())),
+ new Task(FROM_HERE,
+ BindOnce(&VerifySequencedTaskRunnerHandle,
+ base::Unretained(test_task_runner.get())),
TaskTraits().WithShutdownBehavior(GetParam()), TimeDelta()));
verify_task->sequenced_task_runner_ref = test_task_runner;
@@ -548,8 +549,9 @@ TEST_P(TaskSchedulerTaskTrackerTest,
// to |test_task_runner| in its scope per |single_thread_task_runner_ref|
// being set on it.
std::unique_ptr<Task> verify_task(
- new Task(FROM_HERE, Bind(&VerifyThreadTaskRunnerHandle,
- base::Unretained(test_task_runner.get())),
+ new Task(FROM_HERE,
+ BindOnce(&VerifyThreadTaskRunnerHandle,
+ base::Unretained(test_task_runner.get())),
TaskTraits().WithShutdownBehavior(GetParam()), TimeDelta()));
verify_task->single_thread_task_runner_ref = test_task_runner;
@@ -557,7 +559,7 @@ TEST_P(TaskSchedulerTaskTrackerTest,
}
TEST_P(TaskSchedulerTaskTrackerTest, FlushPendingDelayedTask) {
- const Task delayed_task(FROM_HERE, Bind(&DoNothing),
+ const Task delayed_task(FROM_HERE, BindOnce(&DoNothing),
TaskTraits().WithShutdownBehavior(GetParam()),
TimeDelta::FromDays(1));
tracker_.WillPostTask(&delayed_task);
« no previous file with comments | « base/task_scheduler/task_scheduler_impl_unittest.cc ('k') | base/task_scheduler/task_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698