Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: base/deferred_sequenced_task_runner_unittest.cc

Issue 2791243002: Rewrite base::Bind into base::BindOnce on trivial cases in base (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/task_annotator_unittest.cc ('k') | base/files/file_descriptor_watcher_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/deferred_sequenced_task_runner_unittest.cc
diff --git a/base/deferred_sequenced_task_runner_unittest.cc b/base/deferred_sequenced_task_runner_unittest.cc
index e34827ab9eee317244d721b0b77e339822c954f9..a39b2d3485c23787e1408c92923e652c733492fa 100644
--- a/base/deferred_sequenced_task_runner_unittest.cc
+++ b/base/deferred_sequenced_task_runner_unittest.cc
@@ -44,10 +44,9 @@ class DeferredSequencedTaskRunnerTest : public testing::Test,
}
void PostExecuteTask(int task_id) {
- runner_->PostTask(FROM_HERE,
- base::Bind(&DeferredSequencedTaskRunnerTest::ExecuteTask,
- base::Unretained(this),
- task_id));
+ runner_->PostTask(
+ FROM_HERE, base::BindOnce(&DeferredSequencedTaskRunnerTest::ExecuteTask,
+ base::Unretained(this), task_id));
}
void StartRunner() {
@@ -126,16 +125,17 @@ TEST_F(DeferredSequencedTaskRunnerTest, DeferredStartWithMultipleThreads) {
for (int i = 0; i < 5; ++i) {
thread1.task_runner()->PostTask(
FROM_HERE,
- base::Bind(&DeferredSequencedTaskRunnerTest::PostExecuteTask,
- base::Unretained(this), 2 * i));
+ base::BindOnce(&DeferredSequencedTaskRunnerTest::PostExecuteTask,
+ base::Unretained(this), 2 * i));
thread2.task_runner()->PostTask(
FROM_HERE,
- base::Bind(&DeferredSequencedTaskRunnerTest::PostExecuteTask,
- base::Unretained(this), 2 * i + 1));
+ base::BindOnce(&DeferredSequencedTaskRunnerTest::PostExecuteTask,
+ base::Unretained(this), 2 * i + 1));
if (i == 2) {
thread1.task_runner()->PostTask(
- FROM_HERE, base::Bind(&DeferredSequencedTaskRunnerTest::StartRunner,
- base::Unretained(this)));
+ FROM_HERE,
+ base::BindOnce(&DeferredSequencedTaskRunnerTest::StartRunner,
+ base::Unretained(this)));
}
}
}
@@ -157,9 +157,10 @@ TEST_F(DeferredSequencedTaskRunnerTest, ObjectDestructionOrder) {
scoped_refptr<ExecuteTaskOnDestructor> short_lived_object =
new ExecuteTaskOnDestructor(this, 2 * i);
runner_->PostTask(
- FROM_HERE, base::Bind(&DeferredSequencedTaskRunnerTest::DoNothing,
- base::Unretained(this),
- base::RetainedRef(short_lived_object)));
+ FROM_HERE,
+ base::BindOnce(&DeferredSequencedTaskRunnerTest::DoNothing,
+ base::Unretained(this),
+ base::RetainedRef(short_lived_object)));
}
// |short_lived_object| with id |2 * i| should be destroyed before the
// task |2 * i + 1| is executed.
« no previous file with comments | « base/debug/task_annotator_unittest.cc ('k') | base/files/file_descriptor_watcher_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698