Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: components/ntp_tiles/metrics.cc

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/metrics.cc
diff --git a/components/ntp_tiles/metrics.cc b/components/ntp_tiles/metrics.cc
index a2139ae338be27f3c8bb7560d50dab5b7e5af811..b1121c738c70639c7335e21bc8f64b9c72a79777 100644
--- a/components/ntp_tiles/metrics.cc
+++ b/components/ntp_tiles/metrics.cc
@@ -59,7 +59,7 @@ std::string GetSourceHistogramName(NTPTileSource source) {
return std::string();
}
-const char* GetIconTypeSuffix(MostVisitedTileType type) {
+const char* GetIconTypeSuffix(NTPTileType type) {
switch (type) {
case ICON_COLOR:
return kIconTypeSuffixColor;
@@ -84,7 +84,7 @@ void RecordPageImpression(const std::vector<TileImpression>& tiles,
for (int index = 0; index < static_cast<int>(tiles.size()); index++) {
NTPTileSource source = tiles[index].source;
- MostVisitedTileType tile_type = tiles[index].type;
+ NTPTileType tile_type = tiles[index].type;
const GURL& url = tiles[index].url;
UMA_HISTOGRAM_ENUMERATION("NewTabPage.SuggestionsImpression", index,
@@ -120,9 +120,7 @@ void RecordPageImpression(const std::vector<TileImpression>& tiles,
}
}
-void RecordTileClick(int index,
- NTPTileSource source,
- MostVisitedTileType tile_type) {
+void RecordTileClick(int index, NTPTileSource source, NTPTileType tile_type) {
UMA_HISTOGRAM_ENUMERATION("NewTabPage.MostVisited", index, kMaxNumTiles);
std::string histogram = base::StringPrintf(

Powered by Google App Engine
This is Rietveld 408576698