Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: components/ntp_tiles/metrics.h

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/metrics.h
diff --git a/components/ntp_tiles/metrics.h b/components/ntp_tiles/metrics.h
index 009c4942b8be62d4b58e6d3aff742e6ad66a26f2..32b30e5296678c28aadf4305f36b0ac1ac85b169 100644
--- a/components/ntp_tiles/metrics.h
+++ b/components/ntp_tiles/metrics.h
@@ -20,12 +20,11 @@ namespace metrics {
// The visual type of a most visited tile.
//
-// These values must stay in sync with the MostVisitedTileType enum
-// in histograms.xml.
+// These values must stay in sync with the NTPTileType enum in histograms.xml.
//
// A Java counterpart will be generated for this enum.
// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.ntp
-enum MostVisitedTileType {
+enum NTPTileType {
// The icon or thumbnail hasn't loaded yet.
NONE,
// The item displays a site's actual favicon or touch icon.
@@ -45,13 +44,11 @@ enum MostVisitedTileType {
};
struct TileImpression {
- TileImpression(NTPTileSource source,
- MostVisitedTileType type,
- const GURL& url)
+ TileImpression(NTPTileSource source, NTPTileType type, const GURL& url)
: source(source), type(type), url(url) {}
NTPTileSource source;
- MostVisitedTileType type;
+ NTPTileType type;
GURL url;
};
@@ -62,9 +59,7 @@ void RecordPageImpression(const std::vector<TileImpression>& tiles,
rappor::RapporService* rappor_service);
// Records a click on a tile.
-void RecordTileClick(int index,
- NTPTileSource source,
- MostVisitedTileType tile_type);
+void RecordTileClick(int index, NTPTileSource source, NTPTileType tile_type);
} // namespace metrics
} // namespace ntp_tiles

Powered by Google App Engine
This is Rietveld 408576698