Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
index 067927d2a08234c4d4938d98038881247506b930..04052823d340722304e4951b939f7fee1b054f78 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
@@ -7,9 +7,9 @@ package org.chromium.chrome.browser.suggestions;
import android.graphics.drawable.Drawable;
import android.support.annotation.Nullable;
-import org.chromium.chrome.browser.ntp.MostVisitedTileType;
-import org.chromium.chrome.browser.ntp.MostVisitedTileType.MostVisitedTileTypeEnum;
import org.chromium.chrome.browser.ntp.NTPTileSource.NTPTileSourceEnum;
+import org.chromium.chrome.browser.ntp.NTPTileType;
+import org.chromium.chrome.browser.ntp.NTPTileType.NTPTileTypeEnum;
/**
* Holds the details to populate a site suggestion tile.
@@ -23,8 +23,8 @@ public class Tile implements OfflinableSuggestion {
@NTPTileSourceEnum
private final int mSource;
- @MostVisitedTileTypeEnum
- private int mType = MostVisitedTileType.NONE;
+ @NTPTileTypeEnum
+ private int mType = NTPTileType.NONE;
@Nullable
private Drawable mIcon;
@@ -134,18 +134,18 @@ public class Tile implements OfflinableSuggestion {
/**
* @return The visual type of this tile. Valid values are listed in
Michael van Ouwerkerk 2017/03/31 09:01:15 Can this fit on one line?
Marc Treib 2017/04/03 13:23:09 Yep, done.
- * {@link MostVisitedTileType}.
+ * {@link NTPTileType}.
*/
- @MostVisitedTileTypeEnum
+ @NTPTileTypeEnum
public int getType() {
return mType;
}
/**
* Sets the visual type of this tile. Valid values are listed in
- * {@link MostVisitedTileType}.
+ * {@link NTPTileType}.
*/
- public void setType(@MostVisitedTileTypeEnum int type) {
+ public void setType(@NTPTileTypeEnum int type) {
mType = type;
}

Powered by Google App Engine
This is Rietveld 408576698