Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: ios/chrome/browser/ui/ntp/google_landing_controller.mm

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/google_landing_controller.mm
diff --git a/ios/chrome/browser/ui/ntp/google_landing_controller.mm b/ios/chrome/browser/ui/ntp/google_landing_controller.mm
index 108372f2aedeed57e435b62192f0883d32855b8e..0220786b160113d90ec39cc9a1f66e2e1bf085c6 100644
--- a/ios/chrome/browser/ui/ntp/google_landing_controller.mm
+++ b/ios/chrome/browser/ui/ntp/google_landing_controller.mm
@@ -349,7 +349,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
- (void)reloadData;
// Logs a histogram due to a Most Visited item being opened.
- (void)logMostVisitedClick:(const NSUInteger)visitedIndex
- tileType:(ntp_tiles::metrics::MostVisitedTileType)tileType;
+ tileType:(ntp_tiles::metrics::NTPTileType)tileType;
// Returns the size of |_mostVisitedData|.
- (NSUInteger)numberOfItems;
// Returns the number of non empty tiles (as opposed to the placeholder tiles).
@@ -1088,7 +1088,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
}
- (void)logMostVisitedClick:(const NSUInteger)visitedIndex
- tileType:(ntp_tiles::metrics::MostVisitedTileType)tileType {
+ tileType:(ntp_tiles::metrics::NTPTileType)tileType {
new_tab_page_uma::RecordAction(
_browserState, new_tab_page_uma::ACTION_OPENED_MOST_VISITED_ENTRY);
base::RecordAction(UserMetricsAction("MobileNTPMostVisited"));

Powered by Google App Engine
This is Rietveld 408576698