Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Change in ApplyStyleCommand.cpp is subtle:
1. |range| is only used in if close to call isNode.. so move it into 
 the close and make it const.
2. Range is often created where |start| > |end|. We permit create the constructor
 EphemeralRange(Range) with such Range but not permit 
 constructing EphemeralRange(start, end).
 However isNode.. always returns false such |range|. Then check it early in 
 if conditional.

BUG=388681

[yoichio, 2017-03-30 04:46:06]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 04:46:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 05:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 05:46:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yoichio, 2017-03-31 08:01:15]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 08:01:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 09:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 09:28:13]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-04-03 02:03:07]

Description was changed from

==========
Use EphmeralRange insteadof Range in
CompositeEditCommands::isNodeVisiblyContainedWithin()

BUG=388681
==========

to

==========
Use EphmeralRange insteadof Range in
CompositeEditCommands::isNodeVisiblyContainedWithin()

Change in ApplyStyleCommand.cpp is subtle:
1. |range| is only used in if close to call isNode.. so move it into 
 the close and make it const.
2. Range is created where |start| > |end|. We permit create the constructor
 EphemeralRange(Range) with such Range but not permit 
 constructing EphemeralRange(start, end).
 However isNode.. always returns false such |range|. Then check it early in 
 if conditional.

BUG=388681
==========

[yoichio, 2017-04-03 02:03:07]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-04-03 02:03:32]

Description was changed from

==========
Use EphmeralRange insteadof Range in
CompositeEditCommands::isNodeVisiblyContainedWithin()

Change in ApplyStyleCommand.cpp is subtle:
1. |range| is only used in if close to call isNode.. so move it into 
 the close and make it const.
2. Range is created where |start| > |end|. We permit create the constructor
 EphemeralRange(Range) with such Range but not permit 
 constructing EphemeralRange(start, end).
 However isNode.. always returns false such |range|. Then check it early in 
 if conditional.

BUG=388681
==========

to

==========
Use EphmeralRange insteadof Range in
CompositeEditCommands::isNodeVisiblyContainedWithin()

Change in ApplyStyleCommand.cpp is subtle:
1. |range| is only used in if close to call isNode.. so move it into 
 the close and make it const.
2. Range is often created where |start| > |end|. We permit create the
constructor
 EphemeralRange(Range) with such Range but not permit 
 constructing EphemeralRange(start, end).
 However isNode.. always returns false such |range|. Then check it early in 
 if conditional.

BUG=388681
==========

[yoichio, 2017-04-04 01:56:12]

PTAL

[yosin_UTC9, 2017-04-04 04:54:46]

https://codereview.chromium.org/2788473003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
(right):

https://codereview.chromium.org/2788473003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp:866: if
(startNode != editableRoot && start <= end) {
Since this function assumes start <= end, e.g. |startNode =
NodeTraveral::next(*startNode)|,
we should fix call sites to make sure passing start and end in start <= end.