third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2788473003: Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2788473003: Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Patch Set: update Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index 23a25f842ba74b45c22a1b87a3b23338ca128fbd..51fda8b19e789315f7df686305dfce1ea8b34161 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -363,7 +363,8 @@ bool InsertListCommand::doApplyForSingleParagraph(

// If the entire list is selected, then convert the whole list.

if (switchListType &&

- isNodeVisiblyContainedWithin(*listElement, currentSelection)) {

+ isNodeVisiblyContainedWithin(*listElement,

+ EphemeralRange(&currentSelection))) {

bool rangeStartIsInList =

visiblePositionBeforeNode(*listElement).deepEquivalent() ==

createVisiblePosition(currentSelection.startPosition())