third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h - Issue 2788473003: Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

Issue 2788473003: Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Patch Set: update Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

index d4d1f9b32f00e9fa744e3127bc251ca94a08c672..ce07146690c2297ae7f244c1b7359f61873818b3 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

@@ -221,7 +221,7 @@ class CORE_EXPORT CompositeEditCommand : public EditCommand {

Node* splitTreeToNode(Node*, Node*, bool splitAncestor = false);

- static bool isNodeVisiblyContainedWithin(Node&, const Range&);

+ static bool isNodeVisiblyContainedWithin(Node&, const EphemeralRange&);

HeapVector<Member<EditCommand>> m_commands;