Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 844 matching lines @@
   // FIXME: Callers should perform this operation on a Range that includes the
   // br if they want style applied to the empty line.
   if (start == end && isHTMLBRElement(*start.anchorNode()))
     pastEndNode = NodeTraversal::next(*start.anchorNode());
 
   // Start from the highest fully selected ancestor so that we can modify the
   // fully selected node. e.g. When applying font-size: large on <font
   // color="blue">hello</font>, we need to include the font element in our run
   // to generate <font color="blue" size="4">hello</font> instead of <font
   // color="blue"><font size="4">hello</font></font>
-  Range* range = Range::create(startNode->document(), start, end);
   Element* editableRoot = rootEditableElement(*startNode);
-  if (startNode != editableRoot) {
+  if (startNode != editableRoot && start <= end) {

[yosin_UTC9, 2017/04/04 04:54:46]

Since this function assumes start <= end, e.g. |startNode =
NodeTraveral::next(*startNode)|,
we should fix call sites to make sure passing start and end in start <= end.

+    const EphemeralRange range = EphemeralRange(start, end);
     while (editableRoot && startNode->parentNode() != editableRoot &&
-           isNodeVisiblyContainedWithin(*startNode->parentNode(), *range))
+           isNodeVisiblyContainedWithin(*startNode->parentNode(), range))
       startNode = startNode->parentNode();
   }
 
   applyInlineStyleToNodeRange(style, startNode, pastEndNode, editingState);
 }
 
 static bool containsNonEditableRegion(Node& node) {
   if (!hasEditableStyle(node))
     return true;
 
@@ skipping 1141 matching lines @@
 
 DEFINE_TRACE(ApplyStyleCommand) {
   visitor->trace(m_style);
   visitor->trace(m_start);
   visitor->trace(m_end);
   visitor->trace(m_styledInlineElement);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink