Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2787923002: [MD settings] small code health changes (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, Dan Beam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] small code health changes This CL makes changes like adding a _ suffix on private members, removing old comments, and cleaning up extra semi-colons. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2787923002 Cr-Commit-Position: refs/heads/master@{#460985} Committed: https://chromium.googlesource.com/chromium/src/+/a91c0fc5f433c660fd924cfefa8a4fa09db94ac8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M chrome/browser/resources/settings/device_page/layout_behavior.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.js View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/site_list_tests.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
This Cl has a number of small touch-ups. The changes are low priority. There shouldn't ...
3 years, 8 months ago (2017-03-30 21:02:20 UTC) #5
tommycli
lgtm thank you for doing this!!
3 years, 8 months ago (2017-03-30 21:09:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787923002/1
3 years, 8 months ago (2017-03-31 01:11:48 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:44:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a91c0fc5f433c660fd924cfefa8a...

Powered by Google App Engine
This is Rietveld 408576698