chrome/browser/resources/settings/settings_page/settings_subpage.html - Issue 2787923002: [MD settings] small code health changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2787923002: [MD settings] small code health changes (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_page.js ('k') | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_subpage.html

diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.html b/chrome/browser/resources/settings/settings_page/settings_subpage.html

index 38dfd56ce4b1555e801bc13d29b1f7a27d8b6699..c1e7d22b648b5e9463d3d55221622c3b31a06cf3 100644

--- a/chrome/browser/resources/settings/settings_page/settings_subpage.html

+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.html

@@ -18,12 +18,12 @@

padding-bottom: 60px;

}

- .settings-box.first {

+ #headerLine {

min-height: 40px;

padding-top: 8px;

}

- .settings-box.first > h1 {

+ #headerLine > h1 {

-webkit-margin-start: 4px;

}

@@ -59,7 +59,7 @@

-webkit-margin-start: 16px;

}

</style>

- <div class="settings-box first">

+ <div class="settings-box first" id="headerLine">

<paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_"

aria-label="$i18n{back}">

</paper-icon-button>

« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_page.js ('k') | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »