Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2787923002: [MD settings] small code health changes (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
8 <link rel="import" href="../icons.html"> 8 <link rel="import" href="../icons.html">
9 <link rel="import" href="../route.html"> 9 <link rel="import" href="../route.html">
10 <link rel="import" href="settings_subpage_search.html"> 10 <link rel="import" href="settings_subpage_search.html">
11 <link rel="import" href="../settings_shared_css.html"> 11 <link rel="import" href="../settings_shared_css.html">
12 12
13 <dom-module id="settings-subpage"> 13 <dom-module id="settings-subpage">
14 <template> 14 <template>
15 <style include="settings-shared"> 15 <style include="settings-shared">
16 :host { 16 :host {
17 display: block; 17 display: block;
18 padding-bottom: 60px; 18 padding-bottom: 60px;
19 } 19 }
20 20
21 .settings-box.first { 21 #headerLine {
22 min-height: 40px; 22 min-height: 40px;
23 padding-top: 8px; 23 padding-top: 8px;
24 } 24 }
25 25
26 .settings-box.first > h1 { 26 #headerLine > h1 {
27 -webkit-margin-start: 4px; 27 -webkit-margin-start: 4px;
28 } 28 }
29 29
30 #learnMore { 30 #learnMore {
31 @apply(--cr-paper-icon-button-margin); 31 @apply(--cr-paper-icon-button-margin);
32 align-items: center; 32 align-items: center;
33 display: flex; 33 display: flex;
34 height: var(--cr-icon-ripple-size); 34 height: var(--cr-icon-ripple-size);
35 justify-content: center; 35 justify-content: center;
36 position: relative; /* Needed for paper-ripple. */ 36 position: relative; /* Needed for paper-ripple. */
(...skipping 15 matching lines...) Expand all
52 flex: 1; /* Push other items to the end. */ 52 flex: 1; /* Push other items to the end. */
53 font-size: 107.6923%; /* Go to 14px from 13px */ 53 font-size: 107.6923%; /* Go to 14px from 13px */
54 font-weight: 500; 54 font-weight: 500;
55 } 55 }
56 56
57 settings-subpage-search { 57 settings-subpage-search {
58 /* Keep normal icon spacing from subpage-title-extra controls. */ 58 /* Keep normal icon spacing from subpage-title-extra controls. */
59 -webkit-margin-start: 16px; 59 -webkit-margin-start: 16px;
60 } 60 }
61 </style> 61 </style>
62 <div class="settings-box first"> 62 <div class="settings-box first" id="headerLine">
63 <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_" 63 <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_"
64 aria-label="$i18n{back}"> 64 aria-label="$i18n{back}">
65 </paper-icon-button> 65 </paper-icon-button>
66 <h1>[[pageTitle]]</h1> 66 <h1>[[pageTitle]]</h1>
67 <content select=".subpage-title-extra"></content> 67 <content select=".subpage-title-extra"></content>
68 <template is="dom-if" if="[[learnMoreUrl]]"> 68 <template is="dom-if" if="[[learnMoreUrl]]">
69 <a id="learnMore" aria-label="$i18n{learnMore}" 69 <a id="learnMore" aria-label="$i18n{learnMore}"
70 href="[[learnMoreUrl]]" target="_blank"> 70 href="[[learnMoreUrl]]" target="_blank">
71 <iron-icon icon="settings:help-outline"></iron-icon> 71 <iron-icon icon="settings:help-outline"></iron-icon>
72 <paper-ripple class="circle" center></paper-ripple> 72 <paper-ripple class="circle" center></paper-ripple>
73 </a> 73 </a>
74 </template> 74 </template>
75 <template is="dom-if" if="[[searchLabel]]"> 75 <template is="dom-if" if="[[searchLabel]]">
76 <settings-subpage-search label="[[searchLabel]]" 76 <settings-subpage-search label="[[searchLabel]]"
77 on-search-changed="onSearchChanged_"> 77 on-search-changed="onSearchChanged_">
78 </settings-subpage-search> 78 </settings-subpage-search>
79 </template> 79 </template>
80 <template is="dom-if" if="[[showSpinner]]"> 80 <template is="dom-if" if="[[showSpinner]]">
81 <paper-spinner active></paper-spinner> 81 <paper-spinner active></paper-spinner>
82 </template> 82 </template>
83 </div> 83 </div>
84 <content></content> 84 <content></content>
85 </template> 85 </template>
86 <script src="settings_subpage.js"></script> 86 <script src="settings_subpage.js"></script>
87 </dom-module> 87 </dom-module>
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_page.js ('k') | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698