Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2787923002: [MD settings] small code health changes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/sync_page.js
diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js
index 37d603b89c4d58c671b14ebd318d9fd031cb509f..3b65c2c6b38c88b2e65d81540b430f261e533f38 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.js
+++ b/chrome/browser/resources/settings/people_page/sync_page.js
@@ -35,13 +35,6 @@ var SyncPrefsIndividualDataTypes = [
/**
* @fileoverview
* 'settings-sync-page' is the settings page containing sync settings.
- *
- * Example:
- *
- * <iron-animated-pages>
- * <settings-sync-page></settings-sync-page>
- * ... other pages ...
- * </iron-animated-pages>
*/
Polymer({
is: 'settings-sync-page',
@@ -53,7 +46,7 @@ Polymer({
properties: {
/** @private */
- pages: {
+ pages_: {
type: Object,
value: settings.PageStatus,
readOnly: true,
@@ -355,7 +348,7 @@ Polymer({
settings.navigateTo(settings.Route.PEOPLE);
return;
case settings.PageStatus.PASSPHRASE_FAILED:
- if (this.pageStatus_ == this.pages.CONFIGURE &&
+ if (this.pageStatus_ == this.pages_.CONFIGURE &&
this.syncPrefs && this.syncPrefs.passphraseRequired) {
this.$$('#existingPassphraseInput').invalid = true;
}

Powered by Google App Engine
This is Rietveld 408576698