Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2787893004: Fixing select all for contenteditable (Closed)

Created:
3 years, 8 months ago by amaralp
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing select all for contenteditable Don't enable select all if the contenteditable has nothing to select. BUG=696134 Review-Url: https://codereview.chromium.org/2787893004 Cr-Commit-Position: refs/heads/master@{#462762} Committed: https://chromium.googlesource.com/chromium/src/+/099fc50c9790b25cf3ec7bad7aed7b75a8e98c80

Patch Set 1 #

Patch Set 2 : forgot end quote #

Patch Set 3 : format #

Patch Set 4 : check if root editable node has children #

Patch Set 5 : rebase #

Total comments: 4

Patch Set 6 : yosin's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 38 (27 generated)
amaralp
PTAL, there is a layout test failing but I think it is only checking for ...
3 years, 8 months ago (2017-04-04 16:16:31 UTC) #13
yosin_UTC9
On 2017/04/04 at 16:16:31, amaralp wrote: > PTAL, there is a layout test failing but ...
3 years, 8 months ago (2017-04-05 02:12:02 UTC) #14
amaralp
On 2017/04/05 at 02:12:02, yosin wrote: > On 2017/04/04 at 16:16:31, amaralp wrote: > > ...
3 years, 8 months ago (2017-04-05 03:20:04 UTC) #15
yosin_UTC9
On 2017/04/05 at 03:20:04, amaralp wrote: > On 2017/04/05 at 02:12:02, yosin wrote: > > ...
3 years, 8 months ago (2017-04-05 03:40:19 UTC) #16
amaralp
On 2017/04/05 at 03:40:19, yosin wrote: > On 2017/04/05 at 03:20:04, amaralp wrote: > > ...
3 years, 8 months ago (2017-04-05 08:06:45 UTC) #21
yosin_UTC9
On 2017/04/05 at 08:06:45, amaralp wrote: > On 2017/04/05 at 03:40:19, yosin wrote: > > ...
3 years, 8 months ago (2017-04-06 08:25:04 UTC) #26
yosin_UTC9
https://codereview.chromium.org/2787893004/diff/80001/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right): https://codereview.chromium.org/2787893004/diff/80001/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp#newcode2118 third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:2118: Node* root = highestEditableRoot(selection.start()); For safety, we would like ...
3 years, 8 months ago (2017-04-06 08:27:27 UTC) #27
amaralp
https://codereview.chromium.org/2787893004/diff/80001/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right): https://codereview.chromium.org/2787893004/diff/80001/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp#newcode2118 third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:2118: Node* root = highestEditableRoot(selection.start()); On 2017/04/06 at 08:27:27, yosin_UTC9 ...
3 years, 8 months ago (2017-04-06 21:51:21 UTC) #32
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-07 04:51:39 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787893004/100001
3 years, 8 months ago (2017-04-07 05:02:44 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:15:31 UTC) #38
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/099fc50c9790b25cf3ec7bad7aed...

Powered by Google App Engine
This is Rietveld 408576698