third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html - Issue 2787893004: Fixing select all for contenteditable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html

Issue 2787893004: Fixing select all for contenteditable (Closed)

Patch Set: yosin's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html

diff --git a/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html b/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html

index 277bb5fcef9045114ee9bf4759db30132b8368ef..8a37d0ba337db02bb574595c41bd264bbdea2b2c 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html

+++ b/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_contenteditable.html

@@ -6,10 +6,10 @@

test(function() {

var div = document.getElementById('div');

div.focus();

- assert_true(document.queryCommandEnabled('SelectAll'));

+ assert_false(document.queryCommandEnabled('SelectAll'));

div.appendChild(document.createTextNode('x'));

div.focus();

assert_true(document.queryCommandEnabled('SelectAll'));

-}, 'SelectAll is always enabled for contenteditable');

+}, 'SelectAll is not enabled if contenteditable is empty');

</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('j') | no next file with comments »