Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2787893004: Fixing select all for contenteditable (Closed)
Patch Set: yosin's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index d5881a9b3d9ff2c8768ed4514f7e2bc38a4e262d..2e67387a27392c1cbce326f2715d21869221d2d7 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -11567,7 +11567,7 @@ bool testSelectAll(const std::string& html) {
WebInputEvent::TimeStampForTesting);
mouseEvent.button = WebMouseEvent::Button::Right;
- mouseEvent.setPositionInWidget(10, 10);
+ mouseEvent.setPositionInWidget(8, 8);
mouseEvent.clickCount = 1;
webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
runPendingTasks();
@@ -11580,9 +11580,9 @@ TEST_F(WebFrameTest, ContextMenuData) {
EXPECT_TRUE(testSelectAll("<textarea>nonempty</textarea>"));
EXPECT_FALSE(testSelectAll("<input>"));
EXPECT_TRUE(testSelectAll("<input value='nonempty'>"));
- // TODO(amaralp): Empty contenteditable should not have select all enabled.
- EXPECT_TRUE(testSelectAll("<div contenteditable></div>"));
+ EXPECT_FALSE(testSelectAll("<div contenteditable></div>"));
EXPECT_TRUE(testSelectAll("<div contenteditable>nonempty</div>"));
+ EXPECT_TRUE(testSelectAll("<div contenteditable>\n</div>"));
}
TEST_F(WebFrameTest, LocalFrameWithRemoteParentIsTransparent) {
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698