Fixing select all for contenteditable

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11549 matching lines @@
   webView->resize(WebSize(500, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
   webView->setInitialFocus(false);
   runPendingTasks();
 
   WebMouseEvent mouseEvent(WebInputEvent::MouseDown, WebInputEvent::NoModifiers,
                            WebInputEvent::TimeStampForTesting);
 
   mouseEvent.button = WebMouseEvent::Button::Right;
-  mouseEvent.setPositionInWidget(10, 10);
+  mouseEvent.setPositionInWidget(8, 8);
   mouseEvent.clickCount = 1;
   webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
   runPendingTasks();
   webViewHelper.reset();
   return frame.getMenuData().editFlags & WebContextMenuData::CanSelectAll;
 }
 
 TEST_F(WebFrameTest, ContextMenuData) {
   EXPECT_FALSE(testSelectAll("<textarea></textarea>"));
   EXPECT_TRUE(testSelectAll("<textarea>nonempty</textarea>"));
   EXPECT_FALSE(testSelectAll("<input>"));
   EXPECT_TRUE(testSelectAll("<input value='nonempty'>"));
-  // TODO(amaralp): Empty contenteditable should not have select all enabled.
-  EXPECT_TRUE(testSelectAll("<div contenteditable></div>"));
+  EXPECT_FALSE(testSelectAll("<div contenteditable></div>"));
   EXPECT_TRUE(testSelectAll("<div contenteditable>nonempty</div>"));

[yosin_UTC9, 2017/04/06 08:27:27]

Could you add |EXPECT_TRUE(testSelectAll("<div contenteditable>\n</div>"));|?

[amaralp, 2017/04/06 21:51:21]

Done.

 }
 
 TEST_F(WebFrameTest, LocalFrameWithRemoteParentIsTransparent) {
   FrameTestHelpers::TestWebViewClient viewClient;
   FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
   WebView* view = WebView::create(&viewClient, WebPageVisibilityStateVisible);
   view->settings()->setJavaScriptEnabled(true);
   view->setMainFrame(remoteClient.frame());
   WebRemoteFrame* root = view->mainFrame()->toWebRemoteFrame();
   root->setReplicatedOrigin(SecurityOrigin::createUnique());
 
   WebLocalFrameImpl* localFrame = FrameTestHelpers::createLocalChild(root);
   FrameTestHelpers::loadFrame(localFrame, "data:text/html,some page");
 
   // Local frame with remote parent should have transparent baseBackgroundColor.
   Color color = localFrame->frameView()->baseBackgroundColor();
   EXPECT_EQ(Color::transparent, color);
 
   view->close();
 }
 
 }  // namespace blink