Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 2786963002: Revert of Make gl_clear_broken workaround support core profile and use it under AMD Linux Catalyst driver (Closed)

Created:
3 years, 8 months ago by sugoi1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, bsalomon_chromium, vmiura, Corentin Wallez
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make gl_clear_broken workaround support core profile and use it under AMD Linux Catalyst driver (patchset #7 id:120001 of https://codereview.chromium.org/2764833003/ ) Reason for revert: This cl broke the "Builder: Linux Release (AMD R7 240)" bot. See: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20(AMD%20R7%20240) Original issue's description: > Make gl_clear_broken workaround support core profile and use it under AMD Linux Catalyst driver > > Make ClearFrameBuffer use a VAO and add version to shaders in core > profile. Use gl_clear_broken workaround under Linux AMD Catalyst driver > because it ignores clear if it's the only thing rendered to the target > before the target is read. > > BUG=690122 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2764833003 > Cr-Commit-Position: refs/heads/master@{#460282} > Committed: https://chromium.googlesource.com/chromium/src/+/6ca5d0d3ad671604d9a028e71402e9e5ee25f110 TBR=kbr@chromium.org,zmo@chromium.org,xiangze.zhang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=690122 Review-Url: https://codereview.chromium.org/2786963002 Cr-Commit-Position: refs/heads/master@{#460772} Committed: https://chromium.googlesource.com/chromium/src/+/e618b6971a699f5d25d9f1b8c5d3011b8118feab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -112 lines) Patch
M gpu/command_buffer/service/gles2_cmd_clear_framebuffer.h View 3 chunks +3 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc View 9 chunks +12 lines, -73 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc View 5 chunks +24 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
sugoi1
3 years, 8 months ago (2017-03-30 14:41:28 UTC) #2
Created Revert of Make gl_clear_broken workaround support core profile and use
it under AMD Linux Catalyst driver

Powered by Google App Engine
This is Rietveld 408576698