Revert of Make gl_clear_broken workaround support core profile and use it under AMD Linux Catalyst driver

gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GL_GLEXT_PROTOTYPES
 #define GL_GLEXT_PROTOTYPES
 #endif
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 27 matching lines @@
       command_line.AppendSwitchASCII(switches::kGpuDriverBugWorkarounds,
                                      base::IntToString(gpu::GL_CLEAR_BROKEN));
       gl_.InitializeWithCommandLine(GLManager::Options(), command_line);
       DCHECK(gl_.workarounds().gl_clear_broken);
     } else {
       gl_.Initialize(GLManager::Options());
       DCHECK(!gl_.workarounds().gl_clear_broken);
     }
   }
 
+  bool IsApplicable() {
+    // The workaround doesn't use VAOs which would cause a failure on a core
+    // context and the hardware for each the workaround is necessary has a buggy
+    // VAO implementation. So we skip testing the workaround on core profiles.
+    return !GetParam() ||
+           !gl_.context()->GetVersionInfo()->is_desktop_core_profile;
+  }
+
   void InitDraw();
   void SetDrawColor(GLfloat r, GLfloat g, GLfloat b, GLfloat a);
   void SetDrawDepth(GLfloat depth);
   void DrawQuad();
 
   void TearDown() override {
     GLTestHelper::CheckGLError("no errors", __LINE__);
     gl_.Destroy();
   }
 
@@ skipping 45 matching lines @@
 
 void GLClearFramebufferTest::DrawQuad() {
   glDrawArrays(GL_TRIANGLES, 0, 6);
 }
 
 INSTANTIATE_TEST_CASE_P(GLClearFramebufferTestWithParam,
                         GLClearFramebufferTest,
                         ::testing::Values(true, false));
 
 TEST_P(GLClearFramebufferTest, ClearColor) {
+  if (!IsApplicable()) {
+    return;
+  }
+
   glClearColor(1.0f, 0.5f, 0.25f, 0.5f);
   glClear(GL_COLOR_BUFFER_BIT);
 
   // Verify.
   const uint8_t expected[] = {255, 128, 64, 128};
   EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 1 /* tolerance */, expected,
                                         nullptr));
 }
 
 TEST_P(GLClearFramebufferTest, ClearColorWithMask) {
+  if (!IsApplicable()) {
+    return;
+  }
+
   glColorMask(GL_TRUE, GL_FALSE, GL_FALSE, GL_FALSE);
   glClearColor(1.0f, 1.0f, 1.0f, 1.0f);
   glClear(GL_COLOR_BUFFER_BIT);
 
   // Verify.
   const uint8_t expected[] = {255, 0, 0, 0};
   EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 0 /* tolerance */, expected,
                                         nullptr));
 }
 
 // crbug.com/434094
 #if !defined(OS_MACOSX)
 TEST_P(GLClearFramebufferTest, ClearColorWithScissor) {
+  if (!IsApplicable()) {
+    return;
+  }
+
   glClearColor(1.0f, 1.0f, 1.0f, 1.0f);
   glClear(GL_COLOR_BUFFER_BIT);
 
   // Verify.
   const uint8_t expected[] = {255, 255, 255, 255};
   EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 0 /* tolerance */, expected,
                                         nullptr));
 
   glScissor(0, 0, 0, 0);
   glEnable(GL_SCISSOR_TEST);
   glClearColor(0, 0, 0, 0);
   glClear(GL_COLOR_BUFFER_BIT);
 
   // Verify - no changes.
   EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 0 /* tolerance */, expected,
                                         nullptr));
 }
 #endif
 
 TEST_P(GLClearFramebufferTest, ClearDepthStencil) {
+  if (!IsApplicable()) {
+    return;
+  }
+
   const GLuint kStencilRef = 1 << 2;
   InitDraw();
   SetDrawColor(1.0f, 0.0f, 0.0f, 1.0f);
   DrawQuad();
   // Verify.
   const uint8_t kRed[] = {255, 0, 0, 255};
   const uint8_t kGreen[] = {0, 255, 0, 255};
   EXPECT_TRUE(
       GLTestHelper::CheckPixels(0, 0, 1, 1, 0 /* tolerance */, kRed, nullptr));
 
@@ skipping 28 matching lines @@
 
   glClearDepthf(0.9f);
   glClear(GL_DEPTH_BUFFER_BIT);
   DrawQuad();
   // Verify - depth test should have passed, so red.
   EXPECT_TRUE(
       GLTestHelper::CheckPixels(0, 0, 1, 1, 0 /* tolerance */, kRed, nullptr));
 }
 
 }  // namespace gpu