Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2786023002: [Remote suggestions] Remove the unique_ptr wrapper around callbacks (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remote suggestions] Remove the unique_ptr wrapper around callbacks A small cleanup. BUG=676317 Review-Url: https://codereview.chromium.org/2786023002 Cr-Commit-Position: refs/heads/master@{#460716} Committed: https://chromium.googlesource.com/chromium/src/+/d52cc8bc74d7a397a9054951373635aa698e2edf

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
jkrcal
Marc, could you PTAL?
3 years, 8 months ago (2017-03-30 09:09:20 UTC) #4
Marc Treib
lgtm Yay! Thanks for the cleanup!
3 years, 8 months ago (2017-03-30 09:13:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786023002/1
3 years, 8 months ago (2017-03-30 09:48:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 10:23:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d52cc8bc74d7a397a90549513736...

Powered by Google App Engine
This is Rietveld 408576698