Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

Issue 2786023002: [Remote suggestions] Remove the unique_ptr wrapper around callbacks (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
index 015e9ca9aa4a91fa133e1b93dcd5cec3d4ecdf3c..b5b2064eb70521ca01c6986ea79d9ce66a3ba7cb 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
@@ -557,7 +557,7 @@ class RemoteSuggestionsProviderImplTest : public ::testing::Test {
const std::string& json) {
SetUpFetchResponse(json);
service->FetchSuggestions(/*interactive_request=*/true,
- /*callback=*/nullptr);
+ RemoteSuggestionsProvider::FetchStatusCallback());
base::RunLoop().RunUntilIdle();
}
@@ -1731,7 +1731,8 @@ TEST_F(RemoteSuggestionsProviderImplTest,
// background fetch.
simple_test_clock_ptr->Advance(TimeDelta::FromHours(1));
- service->RefetchInTheBackground(/*callback=*/nullptr);
+ service->RefetchInTheBackground(
+ RemoteSuggestionsProvider::FetchStatusCallback());
base::RunLoop().RunUntilIdle();
// TODO(jkrcal): Move together with the pref storage into the scheduler.
EXPECT_EQ(

Powered by Google App Engine
This is Rietveld 408576698