components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc - Issue 2786023002: [Remote suggestions] Remove the unique_ptr wrapper around callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc

Issue 2786023002: [Remote suggestions] Remove the unique_ptr wrapper around callbacks (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc ('k') | components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc

diff --git a/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc b/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc

index 743969a435c2f3a3b92a1a6a85351fc4a55747da..734b2842cc239190afc406c7e6e87de48eacd394 100644

--- a/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc

+++ b/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc

@@ -442,11 +442,9 @@ void RemoteSuggestionsSchedulerImpl::RefetchInTheBackground() {

}

background_fetch_in_progress_ = true;

- provider_->RefetchInTheBackground(

- base::MakeUnique<RemoteSuggestionsProvider::FetchStatusCallback>(

- base::Bind(

- &RemoteSuggestionsSchedulerImpl::RefetchInTheBackgroundFinished,

- base::Unretained(this))));

+ provider_->RefetchInTheBackground(base::Bind(

+ &RemoteSuggestionsSchedulerImpl::RefetchInTheBackgroundFinished,

+ base::Unretained(this)));

}

bool RemoteSuggestionsSchedulerImpl::ShouldRefetchInTheBackgroundNow(