Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider.h

Issue 2786023002: [Remote suggestions] Remove the unique_ptr wrapper around callbacks (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider.h
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider.h b/components/ntp_snippets/remote/remote_suggestions_provider.h
index 4e3ec4d028dba500de5422c0d8118e9e962c96ea..8a6e4f89a36836058079e5bbe17027d9ed42e660 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider.h
+++ b/components/ntp_snippets/remote/remote_suggestions_provider.h
@@ -32,10 +32,7 @@ class RemoteSuggestionsProvider : public ContentSuggestionsProvider {
// triggered by the user and have lower priority on the server. After the
// fetch finished, the provided |callback| will be triggered with the status
// of the fetch (unless nullptr).
- // TODO(jkrcal): Change to FetchStatusCallback callback as callbacks already
- // have is_empty() functionality. crbug.com/676317
- virtual void RefetchInTheBackground(
- std::unique_ptr<FetchStatusCallback> callback) = 0;
+ virtual void RefetchInTheBackground(const FetchStatusCallback& callback) = 0;
virtual const RemoteSuggestionsFetcher* suggestions_fetcher_for_debugging()
const = 0;

Powered by Google App Engine
This is Rietveld 408576698