cc: remove the veto-to-software for complex content.

cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2784683002
Cr-Commit-Position: refs/heads/master@{#465279}
Committed: https://chromium.googlesource.com/chromium/src/+/8e75e9c587155933fe3e775605e18111a6cc2b9c

[Stephen White, 2017-03-28 21:11:00]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
==========

to

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Stephen White, 2017-03-28 21:11:17]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:12:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:12:41]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[Stephen White, 2017-03-28 21:33:43]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
==========

[Stephen White, 2017-03-28 21:33:49]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:34:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 00:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 00:26:53]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2017-04-05 20:19:11]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
==========

to

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Stephen White, 2017-04-05 20:22:06]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

We now only veto-to-msaa if the content is complex, but never
veto to software.

Note: the tests are currently modified to pass simply by expecting
gpu raster always, but we should probably be creating impls with MSAA
enabled, and testing that MSAA gets enabled for vetoed content.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.
==========

[Stephen White, 2017-04-05 20:22:06]

senorblanco@chromium.org changed reviewers:
+ enne@chromium.org

[Stephen White, 2017-04-05 20:22:14]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 20:22:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen White, 2017-04-05 20:37:49]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.
==========

to

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Stephen White, 2017-04-05 20:38:57]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 20:39:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen White, 2017-04-05 21:51:59]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Stephen White, 2017-04-05 21:52:12]

enne@: PTAL. Thanks in advance!

[enne (OOO), 2017-04-05 22:20:09]

lgtm % renaming a variable to be more accurate

https://codereview.chromium.org/2784683002/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2784683002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:1825: } else if
(!content_is_suitable_for_gpu_rasterization_ &&
Sorry to bikeshed, but maybe this should be called something else?
content_needs_msaa_for_gpu_raster_? content_has_too_many_slow_paths_ugh_gosh_?

[commit-bot: I haz the power, 2017-04-05 22:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:50:38]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2017-04-06 14:53:31]

On 2017/04/05 22:20:09, enne wrote:
> lgtm % renaming a variable to be more accurate
> 
>
https://codereview.chromium.org/2784683002/diff/40001/cc/trees/layer_tree_hos...
> File cc/trees/layer_tree_host_impl.cc (right):
> 
>
https://codereview.chromium.org/2784683002/diff/40001/cc/trees/layer_tree_hos...
> cc/trees/layer_tree_host_impl.cc:1825: } else if
> (!content_is_suitable_for_gpu_rasterization_ &&
> Sorry to bikeshed, but maybe this should be called something else?
> content_needs_msaa_for_gpu_raster_? content_has_too_many_slow_paths_ugh_gosh_?

I agree that it needs to be renamed. Unfortunately its tendrils spread into 
quite a few classes, and even into Blink:

https://cs.chromium.org/search/?q=issuitableforgpurasterization&type=cs

As to the shed, here are some random colors:

content_prefers_msaa_ (I like this, although it is anthropomorphizing...)
prefer_msaa_for_content_
content_requires_msaa_
content_suggests_msaa_
content_is_faster_with_msaa_

[enne (OOO), 2017-04-06 17:04:24]

On 2017/04/06 at 14:53:31, senorblanco wrote:
> On 2017/04/05 22:20:09, enne wrote:
> > lgtm % renaming a variable to be more accurate
> > 
> >
https://codereview.chromium.org/2784683002/diff/40001/cc/trees/layer_tree_hos...
> > File cc/trees/layer_tree_host_impl.cc (right):
> > 
> >
https://codereview.chromium.org/2784683002/diff/40001/cc/trees/layer_tree_hos...
> > cc/trees/layer_tree_host_impl.cc:1825: } else if
> > (!content_is_suitable_for_gpu_rasterization_ &&
> > Sorry to bikeshed, but maybe this should be called something else?
> > content_needs_msaa_for_gpu_raster_?
content_has_too_many_slow_paths_ugh_gosh_?
> 
> I agree that it needs to be renamed. Unfortunately its tendrils spread into 
> quite a few classes, and even into Blink:
> 
> https://cs.chromium.org/search/?q=issuitableforgpurasterization&type=cs

Oh :C

Feel free to follow up in another patch and just land this.

> As to the shed, here are some random colors:
> 
> content_prefers_msaa_ (I like this, although it is anthropomorphizing...)
> prefer_msaa_for_content_
> content_requires_msaa_
> content_suggests_msaa_
> content_is_faster_with_msaa_

I like the first two the best, but am happy with any of them.

[Stephen White, 2017-04-18 16:30:32]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2017-04-18 16:30:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 17:30:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492533032659560,
"parent_rev": "14d57a734d7f70b2087ed8db3b833c47d3c7df13", "commit_rev":
"8e75e9c587155933fe3e775605e18111a6cc2b9c"}

[commit-bot: I haz the power, 2017-04-18 17:30:50]

Description was changed from

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: remove the veto-to-software for complex content.

If the content is complex and we have MSAA, we will veto-to-MSAA.
Otherwise, we will always use gpu raster for all content.

This will affect devices with missing or blacklisted MSAA functionality
(e.g., Intel), which will now use GPU raster in all cases where they
would have otherwise vetoed to software.

Most unittests were modified to test for veto-to-MSAA instead of
veto-to-software, since that code remains and should be exercised.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2784683002
Cr-Commit-Position: refs/heads/master@{#465279}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e75e9c587155933fe3e775605e1...
==========

[commit-bot: I haz the power, 2017-04-18 17:30:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8e75e9c587155933fe3e775605e1...