Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 2784683002: cc: remove the veto-to-software for complex content. (Closed)
Patch Set: Remove GpuRasterizationStatus::OFF_CONTENT entirely. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 6b572d3e028481589e2008d7c4a3950c0c3f3f83..0ceb9fe31fb576d9ec38d55ed774036d85b00b60 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -5305,15 +5305,15 @@ class LayerTreeHostTestGpuRasterizationEnabled
// Ensure the suitability bit sticks.
EXPECT_FALSE(layer_->IsSuitableForGpuRasterization());
- EXPECT_FALSE(host_impl->pending_tree()->use_gpu_rasterization());
- EXPECT_FALSE(host_impl->use_gpu_rasterization());
+ EXPECT_TRUE(host_impl->pending_tree()->use_gpu_rasterization());
+ EXPECT_TRUE(host_impl->use_gpu_rasterization());
}
void DidActivateTreeOnThread(LayerTreeHostImpl* host_impl) override {
EXPECT_FALSE(layer_->IsSuitableForGpuRasterization());
- EXPECT_FALSE(host_impl->active_tree()->use_gpu_rasterization());
- EXPECT_FALSE(host_impl->use_gpu_rasterization());
+ EXPECT_TRUE(host_impl->active_tree()->use_gpu_rasterization());
+ EXPECT_TRUE(host_impl->use_gpu_rasterization());
EndTest();
}
@@ -5329,6 +5329,23 @@ MULTI_THREAD_TEST_F(LayerTreeHostTestGpuRasterizationEnabled);
class LayerTreeHostTestGpuRasterizationReenabled
: public LayerTreeHostWithGpuRasterizationTest {
protected:
+ void InitializeSettings(LayerTreeSettings* settings) override {
+ settings->gpu_rasterization_msaa_sample_count = 4;
+ }
+
+ std::unique_ptr<TestCompositorFrameSink> CreateCompositorFrameSink(
+ scoped_refptr<ContextProvider> compositor_context_provider,
+ scoped_refptr<ContextProvider> worker_context_provider) override {
+ std::unique_ptr<TestWebGraphicsContext3D> context =
+ TestWebGraphicsContext3D::Create();
+ context->SetMaxSamples(4);
+ context->set_gpu_rasterization(true);
+ compositor_context_provider =
+ TestContextProvider::Create(std::move(context));
+ return LayerTreeTest::CreateCompositorFrameSink(compositor_context_provider,
+ worker_context_provider);
+ }
+
void SetupTree() override {
LayerTreeHostTest::SetupTree();
@@ -5367,10 +5384,10 @@ class LayerTreeHostTestGpuRasterizationReenabled
void CommitCompleteOnThread(LayerTreeHostImpl* host_impl) override {
SCOPED_TRACE(base::StringPrintf("commit %d", num_commits_));
- if (expected_gpu_enabled_) {
- EXPECT_TRUE(host_impl->use_gpu_rasterization());
+ if (expected_use_msaa_) {
+ EXPECT_TRUE(host_impl->use_msaa());
} else {
- EXPECT_FALSE(host_impl->use_gpu_rasterization());
+ EXPECT_FALSE(host_impl->use_msaa());
}
++num_commits_;
@@ -5385,7 +5402,7 @@ class LayerTreeHostTestGpuRasterizationReenabled
layer_->set_force_unsuitable_for_gpu_rasterization(false);
break;
case 90:
- expected_gpu_enabled_ = true;
+ expected_use_msaa_ = false;
break;
}
PostSetNeedsCommitToMainThread();
@@ -5399,7 +5416,7 @@ class LayerTreeHostTestGpuRasterizationReenabled
FakePictureLayer* layer_;
FakeRecordingSource* recording_source_;
int num_commits_ = 0;
- bool expected_gpu_enabled_ = false;
+ bool expected_use_msaa_ = true;
};
MULTI_THREAD_TEST_F(LayerTreeHostTestGpuRasterizationReenabled);
« cc/trees/layer_tree_host_impl.cc ('K') | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698