Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2783973002: Moving LatencyInfo into a separate component. (Closed)

Created:
3 years, 8 months ago by mfomitchev
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, yusukes+watch_chromium.org, darin (slow to review), jam, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, loading-reviews_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Randy Smith (Not in Mondays), piman+watch_chromium.org, cc-bugs_chromium.org, shuchen+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, Aaron Boodman, mac-reviews_chromium.org, danakj+watch_chromium.org, James Su, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving LatencyInfo into a separate component. This is necessary so that various parts of the GPU code do not need to depend on ui/events. BUG=686865 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2783973002 Cr-Commit-Position: refs/heads/master@{#461475} Committed: https://chromium.googlesource.com/chromium/src/+/3ba450ad80c201c9746279d356137dab519ca2dd

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Include order #

Patch Set 4 : Fixing include order #2 #

Patch Set 5 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -1833 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/ipc/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ipc/cc_param_traits_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/cc_serialization_perftest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/compositor_frame_for_blink.typemap View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/ipc/compositor_frame_metadata.mojom View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/compositor_frame_metadata_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/compositor_frame_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/direct_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/latency_info_swap_promise.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/vulkan_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.h View 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/image_transport_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_tap_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M content/common/input/event_with_latency_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_ack.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/scoped_web_input_event_with_latency_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/gpu_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 5 chunks +1 line, -6 lines 0 comments Download
M ui/events/DEPS View 1 chunk +1 line, -6 lines 0 comments Download
M ui/events/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/blink/event_with_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/web_input_event_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/events/ipc/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/events/ipc/OWNERS View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits_macros.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/events/latency_info.h View 1 chunk +0 lines, -262 lines 0 comments Download
D ui/events/latency_info.cc View 1 chunk +0 lines, -375 lines 0 comments Download
D ui/events/latency_info.dot View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/events/latency_info_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ui/events/mojo/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/event.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/event.typemap View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/mojo/event_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/events/mojo/latency_info.mojom View 1 chunk +0 lines, -111 lines 0 comments Download
D ui/events/mojo/latency_info.typemap View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/events/mojo/latency_info_struct_traits.h View 1 chunk +0 lines, -98 lines 0 comments Download
D ui/events/mojo/latency_info_struct_traits.cc View 1 chunk +0 lines, -300 lines 0 comments Download
M ui/events/mojo/struct_traits_unittest.cc View 3 chunks +0 lines, -91 lines 0 comments Download
M ui/events/mojo/traits_test_service.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/events/mojo/typemaps.gni View 1 chunk +1 line, -4 lines 0 comments Download
A ui/latency/BUILD.gn View 1 chunk +43 lines, -0 lines 0 comments Download
A + ui/latency/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A ui/latency/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/latency/ipc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
A + ui/latency/ipc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/latency/ipc/latency_info_param_traits.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/latency/ipc/latency_info_param_traits.cc View 1 2 3 3 chunks +12 lines, -14 lines 0 comments Download
A + ui/latency/ipc/latency_info_param_traits_macros.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/latency/ipc/latency_info_param_traits_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/latency/latency_info.h View 4 chunks +4 lines, -5 lines 0 comments Download
A + ui/latency/latency_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/latency/latency_info.dot View 1 chunk +1 line, -1 line 0 comments Download
A + ui/latency/latency_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/latency/mojo/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
A + ui/latency/mojo/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
A ui/latency/mojo/OWNERS View 1 chunk +8 lines, -0 lines 0 comments Download
A + ui/latency/mojo/latency_info.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + ui/latency/mojo/latency_info.typemap View 1 chunk +4 lines, -4 lines 0 comments Download
A + ui/latency/mojo/latency_info_struct_traits.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/latency/mojo/latency_info_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/latency/mojo/struct_traits_unittest.cc View 1 chunk +122 lines, -0 lines 0 comments Download
A + ui/latency/mojo/traits_test_service.mojom View 1 chunk +1 line, -5 lines 0 comments Download
A + ui/latency/mojo/typemaps.gni View 1 chunk +1 line, -4 lines 0 comments Download
M ui/surface/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 70 (49 generated)
mfomitchev
tdresser: Please review changes in ui/events, ui/latency fsamuel: Please let me know if you can ...
3 years, 8 months ago (2017-03-29 17:56:44 UTC) #6
mfomitchev
tdresser: can you also please review changes in content/renderer/input, content/common/input, and content/browser/renderer_host/input.
3 years, 8 months ago (2017-03-29 18:01:31 UTC) #7
tdresser
LGTM.
3 years, 8 months ago (2017-03-30 14:50:32 UTC) #10
mfomitchev
tsepez@chromium.org: Please review changes in security review nasko@chromium.org: Please review changes in content/ sadrul@chromium.org: Please ...
3 years, 8 months ago (2017-03-30 18:34:38 UTC) #12
Tom Sepez
RS LGTM on moving files around without introducing new functionality.
3 years, 8 months ago (2017-03-30 18:39:28 UTC) #13
piman
lgtm
3 years, 8 months ago (2017-03-30 22:14:55 UTC) #14
sadrul
lgtm
3 years, 8 months ago (2017-03-30 22:21:43 UTC) #15
nasko
content/ LGTM
3 years, 8 months ago (2017-03-30 22:56:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783973002/1
3 years, 8 months ago (2017-03-30 23:00:34 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/181187) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-03-30 23:06:33 UTC) #20
Fady Samuel
This is generally fine once the bots are happy. LGTM. Thanks!
3 years, 8 months ago (2017-03-31 12:55:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783973002/20001
3 years, 8 months ago (2017-03-31 14:45:24 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/399862)
3 years, 8 months ago (2017-03-31 14:57:01 UTC) #27
mfomitchev
+ben@chromium.org for mojo/ and top-level BUILD.gn
3 years, 8 months ago (2017-03-31 15:09:22 UTC) #31
mfomitchev
Moving beng@ to TBR since the changes are mechanical. If that's not okay - please ...
3 years, 8 months ago (2017-04-03 15:41:40 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783973002/60001
3 years, 8 months ago (2017-04-03 15:43:43 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/182572) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-03 15:47:24 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783973002/80001
3 years, 8 months ago (2017-04-03 16:03:33 UTC) #63
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/380558)
3 years, 8 months ago (2017-04-03 16:45:38 UTC) #65
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783973002/80001
3 years, 8 months ago (2017-04-03 17:29:06 UTC) #67
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 18:21:47 UTC) #70
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3ba450ad80c201c9746279d35613...

Powered by Google App Engine
This is Rietveld 408576698