Renaming gpu swap buffer callbacks and the screenshot latency component.

Renaming gpu swap buffer callbacks as well as a screenshot latency component.

 - Renamed WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT to BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT: the screenshots that are tracked by this component are only the ones that are made via RenderWidgetHostImpl::GetSnapshotFromBrowser. Other screenshots (e.g. ones made via ui::ScreenshotGrabber are not tracked).
 - renamed GPU buffer swap callbacks in render_host to OnGpuSwapBufersCompleted. Previous names were a bit misleading.

TBR=tsepez@chromium.org, 
BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2788893004
Cr-Commit-Position: refs/heads/master@{#461759}
Committed: https://chromium.googlesource.com/chromium/src/+/60addc8dc6c4d88a452b132ad7666d0eb1014fd7

[mfomitchev, 2017-03-31 19:35:46]

Description was changed from

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

BUG=686865
==========

to

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[mfomitchev, 2017-03-31 20:19:58]

Description was changed from

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

 - Renamed WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT to
BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT: the screenshots that are tracked by
this component are only the ones that are made via
RenderWidgetHostImpl::GetSnapshotFromBrowser. Other screenshots (e.g. ones made
via ui::ScreenshotGrabber are not tracked).
 - renamed GPU buffer swap callbacks in render_host to OnGpuSwapBufersCompleted.
Previous names were a bit misleading.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[mfomitchev, 2017-03-31 20:20:29]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 20:20:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-03-31 20:25:08]

mfomitchev@chromium.org changed reviewers:
+ tdresser@chromium.org

[mfomitchev, 2017-03-31 20:25:08]

tdresser: can you please take the first look?

[commit-bot: I haz the power, 2017-03-31 20:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 20:49:26]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mfomitchev, 2017-04-03 14:37:33]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 14:37:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 14:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 14:41:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tdresser, 2017-04-03 15:57:11]

LGTM % Bufers

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/render_widget_host_latency_tracker.h
(right):

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/render_widget_host_latency_tracker.h:60:
void OnGpuSwapBufersCompleted(const ui::LatencyInfo& latency);
Bufers -> Buffers

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:1770: // On Mac, when
using CoreAnmation, there is a delay between when content
CoreAnmation -> CoreAnimation

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.h (right):

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.h:627: void
OnGpuSwapBufersCompletedInternal(const ui::LatencyInfo& latency_info);
Bufers -> Buffers

[mfomitchev, 2017-04-03 17:30:50]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[mfomitchev, 2017-04-03 17:31:00]

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/render_widget_host_latency_tracker.h
(right):

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/render_widget_host_latency_tracker.h:60:
void OnGpuSwapBufersCompleted(const ui::LatencyInfo& latency);
On 2017/04/03 15:57:11, tdresser wrote:
> Bufers -> Buffers

Oops. Done, thanks!

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:1770: // On Mac, when
using CoreAnmation, there is a delay between when content
On 2017/04/03 15:57:11, tdresser wrote:
> CoreAnmation -> CoreAnimation

Done.

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.h (right):

https://codereview.chromium.org/2788893004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.h:627: void
OnGpuSwapBufersCompletedInternal(const ui::LatencyInfo& latency_info);
On 2017/04/03 15:57:11, tdresser wrote:
> Bufers -> Buffers

Done.

[commit-bot: I haz the power, 2017-04-03 17:31:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-03 17:33:20]

mfomitchev@chromium.org changed reviewers:
+ piman@chromium.org

[mfomitchev, 2017-04-03 17:33:20]

piman@chromium.org: Please review changes in 

content/browser/compositor, cc/surfaces

[commit-bot: I haz the power, 2017-04-03 18:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 18:05:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[piman, 2017-04-04 00:23:30]

lgtm

[mfomitchev, 2017-04-04 15:54:04]

Description was changed from

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

 - Renamed WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT to
BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT: the screenshots that are tracked by
this component are only the ones that are made via
RenderWidgetHostImpl::GetSnapshotFromBrowser. Other screenshots (e.g. ones made
via ui::ScreenshotGrabber are not tracked).
 - renamed GPU buffer swap callbacks in render_host to OnGpuSwapBufersCompleted.
Previous names were a bit misleading.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

 - Renamed WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT to
BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT: the screenshots that are tracked by
this component are only the ones that are made via
RenderWidgetHostImpl::GetSnapshotFromBrowser. Other screenshots (e.g. ones made
via ui::ScreenshotGrabber are not tracked).
 - renamed GPU buffer swap callbacks in render_host to OnGpuSwapBufersCompleted.
Previous names were a bit misleading.

TBR=tsepez@chromium.org, 
BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[mfomitchev, 2017-04-04 15:54:55]

Adding tsepez@chromium.org to TBR for a mechanical change to
latency_info_struct_traits.cc

[mfomitchev, 2017-04-04 15:55:05]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2017-04-04 15:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2788893004/#ps40001
(title: "Updating android compositor")

[commit-bot: I haz the power, 2017-04-04 15:55:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 17:14:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491321305666920,
"parent_rev": "c4df23d876fddc1f90b17aeaf4bad970239c6ecf", "commit_rev":
"60addc8dc6c4d88a452b132ad7666d0eb1014fd7"}

[commit-bot: I haz the power, 2017-04-04 17:15:49]

Description was changed from

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

 - Renamed WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT to
BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT: the screenshots that are tracked by
this component are only the ones that are made via
RenderWidgetHostImpl::GetSnapshotFromBrowser. Other screenshots (e.g. ones made
via ui::ScreenshotGrabber are not tracked).
 - renamed GPU buffer swap callbacks in render_host to OnGpuSwapBufersCompleted.
Previous names were a bit misleading.

TBR=tsepez@chromium.org, 
BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Renaming gpu swap buffer callbacks as well as a screenshot latency component.

 - Renamed WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT to
BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT: the screenshots that are tracked by
this component are only the ones that are made via
RenderWidgetHostImpl::GetSnapshotFromBrowser. Other screenshots (e.g. ones made
via ui::ScreenshotGrabber are not tracked).
 - renamed GPU buffer swap callbacks in render_host to OnGpuSwapBufersCompleted.
Previous names were a bit misleading.

TBR=tsepez@chromium.org, 
BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2788893004
Cr-Commit-Position: refs/heads/master@{#461759}
Committed:
https://chromium.googlesource.com/chromium/src/+/60addc8dc6c4d88a452b132ad766...
==========

[commit-bot: I haz the power, 2017-04-04 17:15:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/60addc8dc6c4d88a452b132ad766...