Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 278273002: drive: Change the return type of ResourceMetadata's methods to FileError (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Change the return type of ResourceMetadata's methods to FileError To abort as soon as possible when encoutering serious errors. BUG=None TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -123 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 6 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 10 chunks +28 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 4 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.h View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 4 chunks +39 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 8 chunks +28 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 7 months ago (2014-05-12 05:58:30 UTC) #1
kinaba
lgtm
6 years, 7 months ago (2014-05-12 07:55:38 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-05-12 07:56:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/278273002/1
6 years, 7 months ago (2014-05-12 07:57:03 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 09:25:23 UTC) #5
Message was sent while issue was closed. 
Change committed as 269756

Powered by Google App Engine
This is Rietveld 408576698