drive: Change the return type of ResourceMetadata's methods to FileError

chrome/browser/chromeos/drive/search_metadata.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/search_metadata.h"
 
 #include <algorithm>
 #include <queue>
 
 #include "base/bind.h"
@@ skipping 256 matching lines @@
     if (error != FILE_ERROR_OK)
       return error;
   }
 
   // Prepare the result.
   for (; !result_candidates.empty(); result_candidates.pop()) {
     const ResultCandidate& candidate = *result_candidates.top();
     // The path field of entries in result_candidates are empty at this point,
     // because we don't want to run the expensive metadata DB look up except for
     // the final results. Hence, here we fill the part.
-    base::FilePath path = resource_metadata->GetFilePath(candidate.local_id);
-    if (path.empty())
-      return FILE_ERROR_FAILED;
+    base::FilePath path;
+    error = resource_metadata->GetFilePath(candidate.local_id, &path);
+    if (error != FILE_ERROR_OK)
+      return error;
     bool is_directory = candidate.entry.file_info().is_directory();
     results->push_back(MetadataSearchResult(
         path, is_directory, candidate.highlighted_base_name));
   }
 
   // Reverse the order here because |result_candidates| puts the most
   // uninteresting candidate at the top.
   std::reverse(results->begin(), results->end());
 
   return FILE_ERROR_OK;
@@ skipping 64 matching lines @@
   highlighted_text->append(net::EscapeForHTML(base::UTF16ToUTF8(pre)));
   highlighted_text->append("<b>");
   highlighted_text->append(net::EscapeForHTML(base::UTF16ToUTF8(match)));
   highlighted_text->append("</b>");
   highlighted_text->append(net::EscapeForHTML(base::UTF16ToUTF8(post)));
   return true;
 }
 
 }  // namespace internal
 }  // namespace drive