drive: Change the return type of ResourceMetadata's methods to FileError

chrome/browser/chromeos/drive/directory_loader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/directory_loader.h"
 
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 37 matching lines @@
     if (error != FILE_ERROR_OK)
       return error;
   }
 
   // Get entry.
   error = resource_metadata->GetResourceEntryById(local_id, entry);
   if (error != FILE_ERROR_OK)
     return error;
 
   // Get the local changestamp.
-  *local_changestamp = resource_metadata->GetLargestChangestamp();
-  return FILE_ERROR_OK;
+  return resource_metadata->GetLargestChangestamp(local_changestamp);
 }
 
 FileError UpdateChangestamp(ResourceMetadata* resource_metadata,
                             const DirectoryFetchInfo& directory_fetch_info,
                             base::FilePath* directory_path) {
   // Update the directory changestamp.
   ResourceEntry directory;
   FileError error = resource_metadata->GetResourceEntryById(
       directory_fetch_info.local_id(), &directory);
   if (error != FILE_ERROR_OK)
     return error;
 
   if (!directory.file_info().is_directory())
     return FILE_ERROR_NOT_A_DIRECTORY;
 
   directory.mutable_directory_specific_info()->set_changestamp(
       directory_fetch_info.changestamp());
   error = resource_metadata->RefreshEntry(directory);
   if (error != FILE_ERROR_OK)
     return error;
 
   // Get the directory path.
-  *directory_path = resource_metadata->GetFilePath(
-      directory_fetch_info.local_id());
-  return FILE_ERROR_OK;
+  return resource_metadata->GetFilePath(directory_fetch_info.local_id(),
+                                        directory_path);
 }
 
 }  // namespace
 
 struct DirectoryLoader::ReadDirectoryCallbackState {
   ReadDirectoryEntriesCallback entries_callback;
   FileOperationCallback completion_callback;
   std::set<std::string> sent_entry_names;
 };
 
@@ skipping 477 matching lines @@
 
   // Also notify the observers.
   if (error == FILE_ERROR_OK && !directory_path->empty()) {
     FOR_EACH_OBSERVER(ChangeListLoaderObserver, observers_,
                       OnDirectoryChanged(*directory_path));
   }
 }
 
 }  // namespace internal
 }  // namespace drive