chrome/browser/chromeos/drive/file_system/download_operation.cc - Issue 278273002: drive: Change the return type of ResourceMetadata's methods to FileError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/download_operation.cc

Issue 278273002: drive: Change the return type of ResourceMetadata's methods to FileError (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/create_directory_operation.cc ('k') | chrome/browser/chromeos/drive/file_system/remove_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/download_operation.cc

diff --git a/chrome/browser/chromeos/drive/file_system/download_operation.cc b/chrome/browser/chromeos/drive/file_system/download_operation.cc

index 9847a3092865d7f4e469cbd0cb1615a7aea8983d..fd7c072ea644be7f466c572e4db71b0a5fe8e78a 100644

--- a/chrome/browser/chromeos/drive/file_system/download_operation.cc

+++ b/chrome/browser/chromeos/drive/file_system/download_operation.cc

@@ -183,7 +183,9 @@ FileError CheckPreConditionForEnsureFileDownloadedByLocalId(

base::FilePath* cache_file_path,

base::FilePath* temp_download_file_path,

ResourceEntry* entry) {

- *drive_file_path = params.metadata->GetFilePath(local_id);

+ FileError error = params.metadata->GetFilePath(local_id, drive_file_path);

+ if (error != FILE_ERROR_OK)

+ return error;

return CheckPreConditionForEnsureFileDownloaded(

params.metadata, params.cache, params.temporary_file_directory, local_id,

entry, cache_file_path, temp_download_file_path);