Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: chrome/browser/chromeos/drive/resource_metadata.h

Issue 278273002: drive: Change the return type of ResourceMetadata's methods to FileError (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/resource_metadata.h
diff --git a/chrome/browser/chromeos/drive/resource_metadata.h b/chrome/browser/chromeos/drive/resource_metadata.h
index 3dcc61515f92748e106be66e43ad52372cb2060f..491816379d7bc4c195b9b0f9115274db42dee32f 100644
--- a/chrome/browser/chromeos/drive/resource_metadata.h
+++ b/chrome/browser/chromeos/drive/resource_metadata.h
@@ -48,7 +48,7 @@ class ResourceMetadata {
FileError Reset();
// Returns the largest changestamp.
- int64 GetLargestChangestamp();
+ FileError GetLargestChangestamp(int64* out_value);
// Sets the largest changestamp.
FileError SetLargestChangestamp(int64 value);
@@ -79,20 +79,22 @@ class ResourceMetadata {
FileError RefreshEntry(const ResourceEntry& entry);
// Recursively gets directories under the entry pointed to by |id|.
- void GetSubDirectoriesRecursively(const std::string& id,
- std::set<base::FilePath>* sub_directories);
+ FileError GetSubDirectoriesRecursively(
+ const std::string& id,
+ std::set<base::FilePath>* sub_directories);
// Returns the id of the resource named |base_name| directly under
// the directory with |parent_local_id|.
// If not found, empty string will be returned.
- std::string GetChildId(const std::string& parent_local_id,
- const std::string& base_name);
+ FileError GetChildId(const std::string& parent_local_id,
+ const std::string& base_name,
+ std::string* out_child_id);
// Returns an object to iterate over entries.
scoped_ptr<Iterator> GetIterator();
// Returns virtual file path of the entry.
- base::FilePath GetFilePath(const std::string& id);
+ FileError GetFilePath(const std::string& id, base::FilePath* out_file_path);
// Returns ID of the entry at the given path.
FileError GetIdByPath(const base::FilePath& file_path, std::string* out_id);
« no previous file with comments | « chrome/browser/chromeos/drive/file_system/search_operation.cc ('k') | chrome/browser/chromeos/drive/resource_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698