Add ability to have active window autohide shelf

Add ability to have active window autohide shelf

* Actual implementation of ShellSurface.setSystemUiVisibility
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
* Update flag accordingly from ShellSurface

BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.

Add set_systemui_visibility to wayland

Review-Url: https://codereview.chromium.org/2782223002
Cr-Commit-Position: refs/heads/master@{#460907}
Committed: https://chromium.googlesource.com/chromium/src/+/74669cbfbef72bde5abdecb18e9c7920cca51419

[yorkelee, 2017-03-29 15:27:47]

Description was changed from

==========
Add ability to have active window autohide shelf

* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
* Update flag accordingly from ShellSurface

BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.

Add set_systemui_visibility to wayland
==========

to

==========
Add ability to have active window autohide shelf

* Actual implementation of ShellSurface.setSystemUiVisibility
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
* Update flag accordingly from ShellSurface

BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.

Add set_systemui_visibility to wayland
==========

[yorkelee, 2017-03-29 15:27:47]

yorkelee@google.com changed reviewers:
+ oshima@chromium.org, reveman@chromium.org

[yorkelee, 2017-03-30 02:50:58]

As discussed offline, removed WM_EVENT_AUTOHIDE_SHELF and
WM_EVENT_UNAUTOHIDE_SHELF to simplify the overall implementation.

[reveman, 2017-03-30 07:10:51]

components/exo lgtm

[oshima, 2017-03-30 14:01:27]

https://codereview.chromium.org/2782223002/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2782223002/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_layout_manager.cc:252: }
This should happen only when the WORKSPACE_WINDOW_STATE_FULLSCREEN or
WORKSPACE_WINDOW_STATE_MAXIMIZED.

https://codereview.chromium.org/2782223002/diff/40001/ash/common/wm/window_st...
File ash/common/wm/window_state.h (right):

https://codereview.chromium.org/2782223002/diff/40001/ash/common/wm/window_st...
ash/common/wm/window_state.h:206: // hide_shelf_when_fullscreen.
shelf control is effective only when it's active in general (same in
set_hide_shelf_when_fullscreen).

We probably should consolidate them into one method + enum, but we can do that
later when we need sticky support.

[yorkelee, 2017-03-30 19:34:12]

Addressed comments

https://codereview.chromium.org/2782223002/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2782223002/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_layout_manager.cc:252: }
On 2017/03/30 14:01:27, oshima wrote:
> This should happen only when the WORKSPACE_WINDOW_STATE_FULLSCREEN or
> WORKSPACE_WINDOW_STATE_MAXIMIZED.

Done.

https://codereview.chromium.org/2782223002/diff/40001/ash/common/wm/window_st...
File ash/common/wm/window_state.h (right):

https://codereview.chromium.org/2782223002/diff/40001/ash/common/wm/window_st...
ash/common/wm/window_state.h:206: // hide_shelf_when_fullscreen.
On 2017/03/30 14:01:27, oshima wrote:
> shelf control is effective only when it's active in general (same in
> set_hide_shelf_when_fullscreen).
> 
> We probably should consolidate them into one method + enum, but we can do that
> later when we need sticky support.

Renamed to autohide_shelf_when_fullscreen_or_maximized

[oshima, 2017-03-30 19:35:58]

lgtm with a nit

https://codereview.chromium.org/2782223002/diff/60001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2782223002/diff/60001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_layout_manager.cc:254: //}
clean up?

[yorkelee, 2017-03-30 19:38:37]

https://codereview.chromium.org/2782223002/diff/60001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2782223002/diff/60001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_layout_manager.cc:254: //}
On 2017/03/30 19:35:58, oshima wrote:
> clean up?

Done.

https://codereview.chromium.org/2782223002/diff/60001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_layout_manager.cc:254: //}
On 2017/03/30 19:35:58, oshima wrote:
> clean up?

Done.

[yorkelee, 2017-03-30 19:47:01]

The CQ bit was checked by yorkelee@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:47:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 19:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 19:51:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[yorkelee, 2017-03-30 19:54:56]

The CQ bit was checked by yorkelee@google.com

[yorkelee, 2017-03-30 19:54:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2782223002/#ps80001
(title: "Cleanup of unremoved comment")

[commit-bot: I haz the power, 2017-03-30 19:55:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 20:00:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:00:10]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yorkelee, 2017-03-30 20:01:15]

The CQ bit was checked by yorkelee@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 20:01:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 20:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:59:39]

Dry run: This issue passed the CQ dry run.

[yorkelee, 2017-03-30 22:10:12]

The CQ bit was checked by yorkelee@google.com

[yorkelee, 2017-03-30 22:10:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2782223002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-30 22:10:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:22:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490911812059860,
"parent_rev": "476fddc51fb5cf133f2ce351c6805e65f4cbc4dd", "commit_rev":
"74669cbfbef72bde5abdecb18e9c7920cca51419"}

[commit-bot: I haz the power, 2017-03-30 22:23:45]

Description was changed from

==========
Add ability to have active window autohide shelf

* Actual implementation of ShellSurface.setSystemUiVisibility
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
* Update flag accordingly from ShellSurface

BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.

Add set_systemui_visibility to wayland
==========

to

==========
Add ability to have active window autohide shelf

* Actual implementation of ShellSurface.setSystemUiVisibility
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
* Update flag accordingly from ShellSurface

BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.

Add set_systemui_visibility to wayland

Review-Url: https://codereview.chromium.org/2782223002
Cr-Commit-Position: refs/heads/master@{#460907}
Committed:
https://chromium.googlesource.com/chromium/src/+/74669cbfbef72bde5abdecb18e9c...
==========

[commit-bot: I haz the power, 2017-03-30 22:23:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/74669cbfbef72bde5abdecb18e9c...