Add ability to have active window autohide shelf

ash/common/wm/window_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_WM_WINDOW_STATE_H_
 #define ASH_COMMON_WM_WINDOW_STATE_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
@@ skipping 183 matching lines @@
   // Gets/sets whether the shelf should be hidden when this window is
   // fullscreen.
   bool hide_shelf_when_fullscreen() const {
     return hide_shelf_when_fullscreen_;
   }
 
   void set_hide_shelf_when_fullscreen(bool value) {
     hide_shelf_when_fullscreen_ = value;
   }
 
+  // Gets/sets whether the shelf should be hidden when this window is currently
+  // active. Note: if true, this will override the logic controlled by
+  // hide_shelf_when_fullscreen.

[oshima, 2017/03/30 14:01:27]

shelf control is effective only when it's active in general (same in
set_hide_shelf_when_fullscreen).

We probably should consolidate them into one method + enum, but we can do that
later when we need sticky support.

[yorkelee, 2017/03/30 19:34:12]

Renamed to autohide_shelf_when_fullscreen_or_maximized

+  bool hide_shelf_when_active() const { return hide_shelf_when_active_; }
+
+  void set_hide_shelf_when_active(bool value) {
+    hide_shelf_when_active_ = value;
+  }
+
   // If the minimum visibility is true, ash will try to keep a
   // minimum amount of the window is always visible on the work area
   // when shown.
   // TODO(oshima): Consolidate this and window_position_managed
   // into single parameter to control the window placement.
   bool minimum_visibility() const { return minimum_visibility_; }
   void set_minimum_visibility(bool minimum_visibility) {
     minimum_visibility_ = minimum_visibility;
   }
 
@@ skipping 148 matching lines @@
   bool window_position_managed_;
   bool bounds_changed_by_user_;
   bool ignored_by_shelf_;
   bool can_consume_system_keys_;
   std::unique_ptr<DragDetails> drag_details_;
 
   bool unminimize_to_restore_bounds_;
   bool in_immersive_fullscreen_;
   bool ignore_keyboard_bounds_change_ = false;
   bool hide_shelf_when_fullscreen_;
+  bool hide_shelf_when_active_;
   bool minimum_visibility_;
   bool can_be_dragged_;
   bool cached_always_on_top_;
   bool allow_set_bounds_in_maximized_ = false;
 
   // A property to remember the window position which was set before the
   // auto window position manager changed the window bounds, so that it can get
   // restored when only this one window gets shown.
   std::unique_ptr<gfx::Rect> pre_auto_manage_window_bounds_;
 
   base::ObserverList<WindowStateObserver> observer_list_;
 
   // True to ignore a property change event to avoid reentrance in
   // UpdateWindowStateType()
   bool ignore_property_change_;
 
   std::unique_ptr<State> current_state_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowState);
 };
 
 }  // namespace wm
 }  // namespace ash
 
 #endif  // ASH_COMMON_WM_WINDOW_STATE_H_