Break dependency on core from generated mojom.js files

We want to be able to use the generated mojom.js files on web servers
without having access to the core Mojo system. Currently the only reason
these files depend on core is to get kInvalidHandle, but there's no such
constant on the C++ side anymore.

This CL replaces core.kInvalidHandle with |null| and teaches the handle
converters how to convert null to and from an invalid handle.

R=sky@chromium.org
BUG=372065
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269704

[cpu_(ooo_6.6-7.5), 2014-05-10 01:37:43]

looks good to my untrained eyes.

Does the "{{module.path}}" add value? I could not make it work with it in my
case [1] and require.js recommends against it [2].


[1] But it could have been user error
[2] Their cooking tool puts them in some cases.

[abarth-chromium, 2014-05-10 01:41:27]

On 2014/05/10 01:37:43, cpu wrote:
> Does the "{{module.path}}" add value? I could not make it work with it in my
> case [1] and require.js recommends against it [2].

If you omit the "{{module.path}}" part, then the name of the module is implied
from where the loader found it.  If you put the name explicitly, then you can
cat together all the JS into a single bundle and all the modules will still be
registered with the proper name.

[cpu_(ooo_6.6-7.5), 2014-05-10 01:58:37]

ok, so it is needed if you want to cook things.


note, I am removing myself from reviewers.

[darin (slow to review), 2014-05-10 03:04:20]

LGTM

[abarth-chromium, 2014-05-10 13:38:40]

Hum...  Actually this is used for core.kInvalidHandle...

[darin (slow to review), 2014-05-10 16:56:31]

Hmm... well that is just a constant, so we could redefine it as needed I
suppose.
On May 10, 2014 6:38 AM, <abarth@chromium.org> wrote:

> Hum...  Actually this is used for core.kInvalidHandle...
>
> https://codereview.chromium.org/278093003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[abarth-chromium, 2014-05-10 17:07:55]

On 2014/05/10 16:56:31, darin wrote:
> Hmm... well that is just a constant, so we could redefine it as needed I
> suppose.

Yeah, we could use |null| to represent an invalid handle.  In the current
design, it's a JavaScript object that wraps an actual invalid handle.

In Carlos' scenario, it doesn't matter what we use as an invalid handle because
the real Mojo system isn't around to unwrap the JS object.  We can just make a
core.js module that has a dummy object as kInvalidHandle.

[darin (slow to review), 2014-05-10 17:09:20]

Oh cool. Yeah, null sounds good.
On May 10, 2014 10:07 AM, <abarth@chromium.org> wrote:

> On 2014/05/10 16:56:31, darin wrote:
>
>> Hmm... well that is just a constant, so we could redefine it as needed I
>> suppose.
>>
>
> Yeah, we could use |null| to represent an invalid handle.  In the current
> design, it's a JavaScript object that wraps an actual invalid handle.
>
> In Carlos' scenario, it doesn't matter what we use as an invalid handle
> because
> the real Mojo system isn't around to unwrap the JS object.  We can just
> make a
> core.js module that has a dummy object as kInvalidHandle.
>
> https://codereview.chromium.org/278093003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[abarth-chromium, 2014-05-10 17:21:47]

Done.  PTAL.

[darin (slow to review), 2014-05-10 17:32:00]

lgtm

[abarth-chromium, 2014-05-10 18:29:00]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-05-10 18:30:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/278093003/20001

[commit-bot: I haz the power, 2014-05-10 19:45:08]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-10 19:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 19:54:20]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[abarth-chromium, 2014-05-10 22:04:40]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-05-10 22:05:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/278093003/40001

[commit-bot: I haz the power, 2014-05-11 01:50:43]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-11 02:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-11 02:42:21]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[abarth-chromium, 2014-05-11 06:26:47]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-05-11 06:26:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/278093003/60001

[abarth-chromium, 2014-05-11 06:27:20]

This CL got slightly uglier because I needed to specialize
Converter<gin::Handle<gin::HandleWrapper> > in order to hand |null| for
core.writeMessage.  Yay for unit testing.

[commit-bot: I haz the power, 2014-05-11 14:20:45]

Change committed as 269704

[sky, 2014-05-12 15:22:28]

Nice, LGTM