mojo/public/tools/bindings/generators/mojom_js_generator.py - Issue 278093003: Break dependency on core from generated mojom.js files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 278093003: Break dependency on core from generated mojom.js files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Specialize Converter<gin::Handle<gin::HandleWrapper> > Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_js_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py

index 07e8b0877f6d7263a852d4a36bb061cf87e2f65f..8ab04d78b98a9dbdc802b33d3816e717f3ace514 100644

--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py

@@ -18,11 +18,11 @@ _kind_to_javascript_default_value = {

mojom.INT32: "0",

mojom.UINT32: "0",

mojom.FLOAT: "0",

- mojom.HANDLE: "core.kInvalidHandle",

- mojom.DCPIPE: "core.kInvalidHandle",

- mojom.DPPIPE: "core.kInvalidHandle",

- mojom.MSGPIPE: "core.kInvalidHandle",

- mojom.SHAREDBUFFER: "core.kInvalidHandle",

+ mojom.HANDLE: "null",

+ mojom.DCPIPE: "null",

+ mojom.DPPIPE: "null",

+ mojom.MSGPIPE: "null",

+ mojom.SHAREDBUFFER: "null",

mojom.INT64: "0",

mojom.UINT64: "0",

mojom.DOUBLE: "0",

« no previous file with comments | « mojo/public/tools/bindings/generators/js_templates/module.js.tmpl ('k') | no next file » | no next file with comments »