mojo/public/js/bindings/connector.js - Issue 278093003: Break dependency on core from generated mojom.js files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/js/bindings/connector.js

Issue 278093003: Break dependency on core from generated mojom.js files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Specialize Converter<gin::Handle<gin::HandleWrapper> > Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/js/bindings/connector.js

diff --git a/mojo/public/js/bindings/connector.js b/mojo/public/js/bindings/connector.js

index 51fb7fe96bbeecf6fa0f5f6dfce1ac4c929fb0dc..57745987bc2fda0be449e5eb4908caa9ac2f7ae4 100644

--- a/mojo/public/js/bindings/connector.js

+++ b/mojo/public/js/bindings/connector.js

@@ -24,9 +24,9 @@ define("mojo/public/js/bindings/connector", [

support.cancelWait(this.readWaitCookie_);

this.readWaitCookie_ = null;

}

- if (this.handle_ != core.kInvalidHandle) {

+ if (this.handle_ != null) {

core.close(this.handle_);

- this.handle_ = core.kInvalidHandle;

+ this.handle_ = null;

}

};