mojo/bindings/js/core.cc - Issue 278093003: Break dependency on core from generated mojom.js files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/bindings/js/core.cc

Issue 278093003: Break dependency on core from generated mojom.js files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Specialize Converter<gin::Handle<gin::HandleWrapper> > Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/bindings/js/core.cc

diff --git a/mojo/bindings/js/core.cc b/mojo/bindings/js/core.cc

index dd46594cd63de50ea6075761c302c05f068b45bc..976a5346140c0253e005fc4dc7a4c5e8fcdf190f 100644

--- a/mojo/bindings/js/core.cc

+++ b/mojo/bindings/js/core.cc

@@ -220,10 +220,6 @@ v8::Local<v8::Value> Core::GetModule(v8::Isolate* isolate) {

.SetMethod("writeData", WriteData)

.SetMethod("readData", ReadData)

- // TODO(vtl): Change name of "kInvalidHandle", now that there's no such

- // C++ constant?

- .SetValue("kInvalidHandle", mojo::Handle())

.SetValue("RESULT_OK", MOJO_RESULT_OK)

.SetValue("RESULT_CANCELLED", MOJO_RESULT_CANCELLED)

.SetValue("RESULT_UNKNOWN", MOJO_RESULT_UNKNOWN)

« no previous file with comments | « mojo/apps/js/bindings/connection_unittests.js ('k') | mojo/bindings/js/handle.h » ('j') | no next file with comments »