mojo/apps/js/bindings/connection_unittests.js - Issue 278093003: Break dependency on core from generated mojom.js files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/bindings/connection_unittests.js

Issue 278093003: Break dependency on core from generated mojom.js files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Specialize Converter<gin::Handle<gin::HandleWrapper> > Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/apps/js/bindings/connection_unittests.js

diff --git a/mojo/apps/js/bindings/connection_unittests.js b/mojo/apps/js/bindings/connection_unittests.js

index 91ea8e3494b9e53366b187a18d35d8d7ec691165..0b0a71b2d03a217173fc251b0f5ee776b22be037 100644

--- a/mojo/apps/js/bindings/connection_unittests.js

+++ b/mojo/apps/js/bindings/connection_unittests.js

@@ -174,7 +174,7 @@ define([

var foo = new sample_service.Foo();

foo.bar = new sample_service.Bar();

// TODO(darin): crbug.com/357043: pass null in place of |foo| here.

- connection1.remote.frobinate(foo, true, core.kInvalidHandle);

+ connection1.remote.frobinate(foo, true, null);

// Write failures are not reported.

expect(connection1.encounteredError()).toBeFalsy();

« no previous file with comments | « no previous file | mojo/bindings/js/core.cc » ('j') | no next file with comments »