Continue to clean c_str() calls.

Continue to clean c_str() calls.

When a result of |string.c_str()| expression is passed to a function that takes
a StringPiece, it will measure the length of the string using strlen() function.
This is useless operation because we know the length already.

No behaviour changes.

BUG=679479
Review-Url: https://codereview.chromium.org/2779893005
Cr-Commit-Position: refs/heads/master@{#460501}
Committed: https://chromium.googlesource.com/chromium/src/+/4179f17c901660139200edfcc751c2a7d9b5d03e

[Andrey Kraynov, 2017-03-28 21:15:26]

iceman@yandex-team.ru changed reviewers:
+ jam@chromium.org

[Andrey Kraynov, 2017-03-28 21:15:26]

Hi!

This a final part of cleaning these c_str() calls from the codebase.
CL consists of very simple changes, but it affects a lot of different files, so
I decided to invite a high level OWNER for review.
Is it possible to work with this CL or should I split it into parts?

Could you take a look please?
Thanks in advance!

[grt (UTC plus 2), 2017-03-29 08:54:54]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2017-03-29 08:54:54]

chrome/installer/util lgtm

[jam, 2017-03-29 14:50:36]

lgtm

[Andrey Kraynov, 2017-03-29 15:01:46]

The CQ bit was checked by iceman@yandex-team.ru

[commit-bot: I haz the power, 2017-03-29 15:02:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 15:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:15:32]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Andrey Kraynov, 2017-03-29 17:56:53]

The CQ bit was checked by iceman@yandex-team.ru

[Andrey Kraynov, 2017-03-29 17:56:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2779893005/#ps20001
(title: "Revert changes in font_service_app.cc")

[commit-bot: I haz the power, 2017-03-29 17:57:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 19:50:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490810213581250,
"parent_rev": "7ca3ccf74e804e13da4c622177f6fc6787019c1e", "commit_rev":
"4179f17c901660139200edfcc751c2a7d9b5d03e"}

[commit-bot: I haz the power, 2017-03-29 19:50:58]

Description was changed from

==========
Continue to clean c_str() calls.

When a result of |string.c_str()| expression is passed to a function that takes
a StringPiece, it will measure the length of the string using strlen() function.
This is useless operation because we know the length already.

No behaviour changes.

BUG=679479
==========

to

==========
Continue to clean c_str() calls.

When a result of |string.c_str()| expression is passed to a function that takes
a StringPiece, it will measure the length of the string using strlen() function.
This is useless operation because we know the length already.

No behaviour changes.

BUG=679479

Review-Url: https://codereview.chromium.org/2779893005
Cr-Commit-Position: refs/heads/master@{#460501}
Committed:
https://chromium.googlesource.com/chromium/src/+/4179f17c901660139200edfcc751...
==========

[commit-bot: I haz the power, 2017-03-29 19:51:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4179f17c901660139200edfcc751...