Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: components/webcrypto/algorithms/test_helpers.cc

Issue 2779893005: Continue to clean c_str() calls. (Closed)
Patch Set: Revert changes in font_service_app.cc Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/webcrypto/algorithms/test_helpers.cc
diff --git a/components/webcrypto/algorithms/test_helpers.cc b/components/webcrypto/algorithms/test_helpers.cc
index 8138f0d5493d9739a7c0508306a4c4b870794860..64e0cf7b0e05753827eca48bb896a356f55ac219 100644
--- a/components/webcrypto/algorithms/test_helpers.cc
+++ b/components/webcrypto/algorithms/test_helpers.cc
@@ -464,8 +464,7 @@ std::unique_ptr<base::DictionaryValue> GetJwkDictionary(
if (!Base64DecodeUrlSafe(value_string, &k_value))
return ::testing::AssertionFailure() << "Base64DecodeUrlSafe(k) failed";
if (!base::LowerCaseEqualsASCII(
- base::HexEncode(k_value.data(), k_value.size()),
- k_expected_hex.c_str())) {
+ base::HexEncode(k_value.data(), k_value.size()), k_expected_hex)) {
return ::testing::AssertionFailure() << "Expected 'k' to be "
<< k_expected_hex
<< " but found something different";
@@ -504,8 +503,7 @@ std::unique_ptr<base::DictionaryValue> GetJwkDictionary(
if (!Base64DecodeUrlSafe(value_string, &e_value))
return ::testing::AssertionFailure() << "Base64DecodeUrlSafe(e) failed";
if (!base::LowerCaseEqualsASCII(
- base::HexEncode(e_value.data(), e_value.size()),
- e_expected_hex.c_str())) {
+ base::HexEncode(e_value.data(), e_value.size()), e_expected_hex)) {
return ::testing::AssertionFailure() << "Expected 'e' to be "
<< e_expected_hex
<< " but found something different";
« no previous file with comments | « components/translate/core/browser/translate_prefs.cc ('k') | content/browser/devtools/devtools_http_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698