components/omnibox/browser/omnibox_edit_model.cc - Issue 2779893005: Continue to clean c_str() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_edit_model.cc

Issue 2779893005: Continue to clean c_str() calls. (Closed)

Patch Set: Revert changes in font_service_app.cc Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/omnibox_edit_model.cc

diff --git a/components/omnibox/browser/omnibox_edit_model.cc b/components/omnibox/browser/omnibox_edit_model.cc

index 3e195f8bb0ac10890e77d55f23da405a34e1a9ce..410347bbba5e734c24c08f829aa58f6f03b12192 100644

--- a/components/omnibox/browser/omnibox_edit_model.cc

+++ b/components/omnibox/browser/omnibox_edit_model.cc

@@ -809,8 +809,8 @@ void OmniboxEditModel::ClearKeyword() {

// State 4 above.

is_keyword_hint_ = true;

const base::string16 window_text = keyword_ + view_->GetText();

- view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length(),

- false, true);

+ view_->SetWindowTextAndCaretPos(window_text, keyword_.length(), false,

+ true);

} else {

// States 1-3 above.

view_->OnBeforePossibleChange();