chrome/installer/util/google_chrome_distribution.cc - Issue 2779893005: Continue to clean c_str() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 2779893005: Continue to clean c_str() calls. (Closed)

Patch Set: Revert changes in font_service_app.cc Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index 12a6fa224b96476a7ff644580f7c6a6f9dc8d8e6..d31327705139ec4f6d69bba16c41b07623eccae4 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -48,7 +48,7 @@ base::string16 LocalizeUrl(const wchar_t* url) {

base::string16 language;

if (!GoogleUpdateSettings::GetLanguage(&language))

language = L"en-US"; // Default to US English.

- return base::ReplaceStringPlaceholders(url, language.c_str(), NULL);

+ return base::ReplaceStringPlaceholders(url, language, NULL);

}

base::string16 GetUninstallSurveyUrl() {