Do not build Password Reuse on Android and iOS

Do not build Password Reuse on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't work, so let's stop building it and save some performance and binary size.

BUG=657041, 706392
Review-Url: https://codereview.chromium.org/2777283004
Cr-Commit-Position: refs/heads/master@{#461672}
Committed: https://chromium.googlesource.com/chromium/src/+/841eab11c2273bb100fbd927a9e47411838cc6b5

[dvadym, 2017-03-29 12:03:57]

Description was changed from

==========
Do not build Password Reuse classes on Android and iOS

BUG=657041
==========

to

==========
Do not build Password Reuse classes on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041
==========

[dvadym, 2017-03-29 12:03:57]

dvadym@chromium.org changed reviewers:
+ vabr@chromium.org

[dvadym, 2017-03-29 12:04:13]

Description was changed from

==========
Do not build Password Reuse classes on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041
==========

to

==========
Do not build Password Reuse on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041
==========

[dvadym, 2017-03-29 12:04:42]

Hi Vaclav,

 could you please review this CL?

Regards,
Vadym

[vabr (Chromium), 2017-03-29 13:14:19]

Hi Vadym,

Is this a temporary situation for Android? Is it temporary for iOS? In cases
where it is temporary, please add a TODO comment referencing a bug tracking
unblocking the password reuse support.

Other than that, LGTM with a comment.

Cheers,
Vaclav

https://codereview.chromium.org/2777283004/diff/60001/chrome/browser/password...
File chrome/browser/password_manager/chrome_password_manager_client.h (right):

https://codereview.chromium.org/2777283004/diff/60001/chrome/browser/password...
chrome/browser/password_manager/chrome_password_manager_client.h:133: #if
!defined(OS_ANDROID) && !defined(OS_IOS)
No need for !defined(OS_IOS) in //chrome. Unlike in the past, after iOS
unforking, the dependencies are now strictly enforced, so nothing in //chrome
gets compiled on iOS.

[dvadym, 2017-03-29 13:46:36]

Thanks for review Vaclav! For ios it's permanent, for Android it's temporary,
I've created a bug and added TODO

https://codereview.chromium.org/2777283004/diff/60001/chrome/browser/password...
File chrome/browser/password_manager/chrome_password_manager_client.h (right):

https://codereview.chromium.org/2777283004/diff/60001/chrome/browser/password...
chrome/browser/password_manager/chrome_password_manager_client.h:133: #if
!defined(OS_ANDROID) && !defined(OS_IOS)
On 2017/03/29 13:14:19, vabr (Chromium) wrote:
> No need for !defined(OS_IOS) in //chrome. Unlike in the past, after iOS
> unforking, the dependencies are now strictly enforced, so nothing in //chrome
> gets compiled on iOS.
thanks, removed IOS.

[dvadym, 2017-03-29 13:47:00]

Description was changed from

==========
Do not build Password Reuse on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041
==========

to

==========
Do not build Password Reuse on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041, 706392
==========

[dvadym, 2017-03-29 13:47:47]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 13:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 14:33:59]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dvadym, 2017-03-29 16:29:52]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-03-29 16:29:53]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2777283004/#ps80001
(title: "Added comments")

[commit-bot: I haz the power, 2017-03-29 16:30:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:33:15]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dvadym, 2017-03-30 08:38:41]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-03-30 08:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 09:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 09:30:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dvadym, 2017-04-03 13:38:06]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 13:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 14:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 14:15:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dvadym, 2017-04-03 14:20:34]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-04-03 14:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2777283004/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-03 14:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 14:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 14:59:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dvadym, 2017-04-04 09:00:04]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 09:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-04 09:51:59]

Patch set 7 LGTM.
Thanks!
Vaclav

[dvadym, 2017-04-04 09:58:57]

The CQ bit was unchecked by dvadym@chromium.org

[dvadym, 2017-04-04 09:58:58]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-04-04 09:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 10:08:59]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491299938901360,
"parent_rev": "cdc707f2ed4d9fa302d5c81259ac67618d6c2b56", "commit_rev":
"841eab11c2273bb100fbd927a9e47411838cc6b5"}

[commit-bot: I haz the power, 2017-04-04 10:09:49]

Description was changed from

==========
Do not build Password Reuse on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041, 706392
==========

to

==========
Do not build Password Reuse on Android and iOS.

On both of these OS Password Reuse logic doesn't implemented fully and doesn't
work, so let's stop building it and save some performance and binary size.

BUG=657041, 706392

Review-Url: https://codereview.chromium.org/2777283004
Cr-Commit-Position: refs/heads/master@{#461672}
Committed:
https://chromium.googlesource.com/chromium/src/+/841eab11c2273bb100fbd927a9e4...
==========

[commit-bot: I haz the power, 2017-04-04 10:09:51]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/841eab11c2273bb100fbd927a9e4...