Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 2777283004: Do not build Password Reuse on Android and iOS (Closed)
Patch Set: Changed #ifdef to OS defines Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // Callable for tests. 123 // Callable for tests.
124 ChromePasswordManagerClient(content::WebContents* web_contents, 124 ChromePasswordManagerClient(content::WebContents* web_contents,
125 autofill::AutofillClient* autofill_client); 125 autofill::AutofillClient* autofill_client);
126 126
127 private: 127 private:
128 friend class content::WebContentsUserData<ChromePasswordManagerClient>; 128 friend class content::WebContentsUserData<ChromePasswordManagerClient>;
129 129
130 // content::WebContentsObserver overrides. 130 // content::WebContentsObserver overrides.
131 void DidStartNavigation( 131 void DidStartNavigation(
132 content::NavigationHandle* navigation_handle) override; 132 content::NavigationHandle* navigation_handle) override;
133 // TODO(crbug.com/706392): Fix password reuse detection for Android.
134 #if !defined(OS_ANDROID)
133 void DidFinishNavigation( 135 void DidFinishNavigation(
134 content::NavigationHandle* navigation_handle) override; 136 content::NavigationHandle* navigation_handle) override;
135 137
136 // content::RenderWidgetHost::InputEventObserver overrides. 138 // content::RenderWidgetHost::InputEventObserver overrides.
137 void OnInputEvent(const blink::WebInputEvent&) override; 139 void OnInputEvent(const blink::WebInputEvent&) override;
140 #endif
138 141
139 // Given |bounds| in the renderers coordinate system, return the same bounds 142 // Given |bounds| in the renderers coordinate system, return the same bounds
140 // in the screens coordinate system. 143 // in the screens coordinate system.
141 gfx::RectF GetBoundsInScreenSpace(const gfx::RectF& bounds); 144 gfx::RectF GetBoundsInScreenSpace(const gfx::RectF& bounds);
142 145
143 // Checks if the current page fulfils the conditions for the password manager 146 // Checks if the current page fulfils the conditions for the password manager
144 // to be active on it, for example Sync credentials are not saved or auto 147 // to be active on it, for example Sync credentials are not saved or auto
145 // filled. 148 // filled.
146 bool IsPasswordManagementEnabledForCurrentPage() const; 149 bool IsPasswordManagementEnabledForCurrentPage() const;
147 150
(...skipping 16 matching lines...) Expand all
164 #if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE) 167 #if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
165 // Return true if we can set PasswordProtectionService in 168 // Return true if we can set PasswordProtectionService in
166 // |password_reuse_detection_manager_|. 169 // |password_reuse_detection_manager_|.
167 static bool CanSetPasswordProtectionService(); 170 static bool CanSetPasswordProtectionService();
168 #endif 171 #endif
169 172
170 Profile* const profile_; 173 Profile* const profile_;
171 174
172 password_manager::PasswordManager password_manager_; 175 password_manager::PasswordManager password_manager_;
173 176
177 // TODO(crbug.com/706392): Fix password reuse detection for Android.
178 #if !defined(OS_ANDROID)
174 password_manager::PasswordReuseDetectionManager 179 password_manager::PasswordReuseDetectionManager
175 password_reuse_detection_manager_; 180 password_reuse_detection_manager_;
181 #endif
176 182
177 password_manager::ContentPasswordManagerDriverFactory* driver_factory_; 183 password_manager::ContentPasswordManagerDriverFactory* driver_factory_;
178 184
179 // As a mojo service, will be registered into service registry 185 // As a mojo service, will be registered into service registry
180 // of the main frame host by ChromeContentBrowserClient 186 // of the main frame host by ChromeContentBrowserClient
181 // once main frame host was created. 187 // once main frame host was created.
182 password_manager::CredentialManagerImpl credential_manager_impl_; 188 password_manager::CredentialManagerImpl credential_manager_impl_;
183 189
184 content::WebContentsFrameBindingSet<autofill::mojom::PasswordManagerClient> 190 content::WebContentsFrameBindingSet<autofill::mojom::PasswordManagerClient>
185 password_manager_client_bindings_; 191 password_manager_client_bindings_;
(...skipping 14 matching lines...) Expand all
200 std::unique_ptr<password_manager::LogManager> log_manager_; 206 std::unique_ptr<password_manager::LogManager> log_manager_;
201 207
202 // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the 208 // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the
203 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'. 209 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
204 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_; 210 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_;
205 211
206 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 212 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
207 }; 213 };
208 214
209 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 215 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698