components/password_manager/core/browser/password_manager_test_utils.cc - Issue 2777283004: Do not build Password Reuse on Android and iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_test_utils.cc

Issue 2777283004: Do not build Password Reuse on Android and iOS (Closed)

Patch Set: Changed #ifdef to OS defines Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_test_utils.h ('k') | components/password_manager/core/browser/password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_test_utils.cc

diff --git a/components/password_manager/core/browser/password_manager_test_utils.cc b/components/password_manager/core/browser/password_manager_test_utils.cc

index 4fd519336427568ab725a215770a453dd01a10b9..c5c3461e2dd43853bd26bc911bbc94b4d6b1b16c 100644

--- a/components/password_manager/core/browser/password_manager_test_utils.cc

+++ b/components/password_manager/core/browser/password_manager_test_utils.cc

@@ -104,8 +104,11 @@ MockPasswordStoreObserver::MockPasswordStoreObserver() {}

MockPasswordStoreObserver::~MockPasswordStoreObserver() {}

+// TODO(crbug.com/706392): Fix password reuse detection for Android.

+#if !defined(OS_ANDROID) && !defined(OS_IOS)

MockPasswordReuseDetectorConsumer::MockPasswordReuseDetectorConsumer() {}

MockPasswordReuseDetectorConsumer::~MockPasswordReuseDetectorConsumer() {}

+#endif

} // namespace password_manager